Skip to content

Commit

Permalink
made types consistent with those defined in Hack
Browse files Browse the repository at this point in the history
  • Loading branch information
fabpot committed Apr 13, 2014
1 parent 31fb686 commit f6e3889
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
6 changes: 3 additions & 3 deletions Process.php
Expand Up @@ -776,7 +776,7 @@ public function setTimeout($timeout)
*/
public function setTty($tty)
{
$this->tty = (Boolean) $tty;
$this->tty = (bool) $tty;

return $this;
}
Expand Down Expand Up @@ -928,7 +928,7 @@ public function getEnhanceWindowsCompatibility()
*/
public function setEnhanceWindowsCompatibility($enhance)
{
$this->enhanceWindowsCompatibility = (Boolean) $enhance;
$this->enhanceWindowsCompatibility = (bool) $enhance;

return $this;
}
Expand Down Expand Up @@ -956,7 +956,7 @@ public function getEnhanceSigchildCompatibility()
*/
public function setEnhanceSigchildCompatibility($enhance)
{
$this->enhanceSigchildCompatibility = (Boolean) $enhance;
$this->enhanceSigchildCompatibility = (bool) $enhance;

return $this;
}
Expand Down
8 changes: 4 additions & 4 deletions ProcessPipes.php
Expand Up @@ -35,8 +35,8 @@ class ProcessPipes

public function __construct($useFiles, $ttyMode)
{
$this->useFiles = (Boolean) $useFiles;
$this->ttyMode = (Boolean) $ttyMode;
$this->useFiles = (bool) $useFiles;
$this->ttyMode = (bool) $ttyMode;

// Fix for PHP bug #51800: reading from STDOUT pipe hangs forever on Windows if the output is too big.
// Workaround for this problem is to use temporary files instead of pipes on Windows platform.
Expand Down Expand Up @@ -180,10 +180,10 @@ public function readAndCloseHandles($blocking)
public function hasOpenHandles()
{
if (!$this->useFiles) {
return (Boolean) $this->pipes;
return (bool) $this->pipes;
}

return (Boolean) $this->pipes && (Boolean) $this->fileHandles;
return (bool) $this->pipes && (bool) $this->fileHandles;
}

/**
Expand Down

0 comments on commit f6e3889

Please sign in to comment.