Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] Consider making the database charset configurable #19

Closed
javiereguiluz opened this issue Apr 3, 2017 · 2 comments
Closed

Comments

@javiereguiluz
Copy link
Member

Right now the charset is hardcoded as UTF8:

# /etc/packages/doctrine.yml
doctrine:
    dbal:
        # ...
        charset: UTF8

This is of course a wise default value ... but lately is more and more common to have to change this config value to utf8mb4, because that's the value needed by MySQL to store emojis correctly 😱

If #18 is considered, making this value configurable would be easy:

# Before
###> doctrine/doctrine-bundle ###
DB_URL='mysql://root@127.0.0.1:3306/symfony'
###< doctrine/doctrine-bundle ###

# After
###> doctrine/doctrine-bundle ###
DB_URL='mysql://root@127.0.0.1:3306/symfony?charset=utf8'
###< doctrine/doctrine-bundle ###
@nicolas-grekas
Copy link
Member

👍 would be awesome to have utf8mb4 as default for mysql

@fabpot
Copy link
Member

fabpot commented Apr 6, 2017

Done :)

@fabpot fabpot closed this as completed Apr 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants