Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symfony browser-kit in require dependencies #16

Closed
wants to merge 1 commit into from
Closed

Symfony browser-kit in require dependencies #16

wants to merge 1 commit into from

Conversation

simPod
Copy link

@simPod simPod commented Jan 25, 2018

In Client.php there's browser kit used use Symfony\Component\BrowserKit

However, it is not explicitely required by this lib and I think it should be. I think it's a sub dependency and therefore shouldn't be necessary to require it as direct dependency in my project.

What are your thoughts?

@nicolas-grekas
Copy link
Member

Please not that all the work happen on symfony/symfony, please use this repositories for your future PRs.
About your question, many people do use the HttpKernel component without ever using the Client class.
This is why BrowserKit is an optional dependency: you need it only if you use this class.
This is how we manage dependencies on all components: only those mandatory are listed in "require".

@simPod
Copy link
Author

simPod commented Feb 2, 2018

Shouldn't that be separated into multiple components then? Personally, I think the library should be fully working unit. Without this it is not as it contains unclear defect hidden in not requiring required dependency for its part.

@nicolas-grekas
Copy link
Member

That would make maintenance harder for the community, we don't have infinite resources so we must make pragmatic compromises.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants