Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong branch for tag 2.3.1 #45

Closed
blaugueux opened this issue Jun 12, 2013 · 7 comments
Closed

Wrong branch for tag 2.3.1 #45

blaugueux opened this issue Jun 12, 2013 · 7 comments

Comments

@blaugueux
Copy link
Contributor

@Seldaek The 2.3.1 tag have been made on the master branch instead of the 2.3 branch.

Now when installing symfony 2.3.1 monolog-bundle require monolog-brige >=2.4-dev

  Problem 1
- Installation request for symfony/monolog-bundle 2.3.1 -> satisfiable by symfony/monolog-bundle[v2.3.1].
- symfony/monolog-bundle v2.3.1 requires symfony/monolog-bridge >=2.4-dev,<3.0 -> no matching package found.
@blaugueux
Copy link
Contributor Author

ping @fabpot

@kingcrunch
Copy link

👍

@fabpot
Copy link
Member

fabpot commented Jun 18, 2013

my fault here. What would be the best strategy to "fix" the situation? Retag 2.3.1 correctly bu removing the current tag and force update on Packagist? ping @Seldaek

@Seldaek
Copy link
Member

Seldaek commented Jun 18, 2013

@fabpot retagging is an option but not so nice. We could just tag a 2.3.2 properly from the 2.3 branch, but ultimately what I would like is a plan for the next releases. Should bundles really be synced to symfony? If yes then should you or me do the tag? The current situation is a mess, I never know when you'll tag, or from which branch, etc. It requires a lot of synchronization which is not so great.

@stof
Copy link
Member

stof commented Jun 18, 2013

I don't think we should force syncing with symfony releases.
For instance, we never released a 2.2 version of AsseticBundle as 2.1 was working with both Symfony versions, thus reducing the maintenance (and then, it has been released as 2.3 which seems pretty weird to me). A similar issue happens for FrameworkExtraBundle: 2.1, 2.2 and master could all work with all symfony versions as of 2.1, except that the composer requirements are forbidding to use the latest features in a 2.2 project.

As we have separate repositories, it would make sense to release these bundles when they have new features, and reducing the number of maintained branches to the minimum needed (which should be 1 now as far as Symfony is concerned as Symfony should not be allowed to break BC anymore requiring to change the bundle)

@fabpot
Copy link
Member

fabpot commented Jun 18, 2013

I agree that the current situation si not clear. I agree that syncing releases is not required. So, from now on, I will let you guys deals with tagging.

@Seldaek
Copy link
Member

Seldaek commented Jun 18, 2013

OK I just deleted the 2.3.1 tag, no need to retag since nothing changed since 2.3.0, it wasn't installable anyway before so I don't think that'll create any problem.

@Seldaek Seldaek closed this as completed Jun 18, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants