Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add swup progress bar plugin to docs #1040

Merged
merged 1 commit into from Aug 15, 2023
Merged

Conversation

yassinefikri
Copy link

@yassinefikri yassinefikri commented Aug 7, 2023

Q A
Bug fix? no
New feature? no
Tickets none
License MIT

updating docs to include swup progress bar plugin as example

@weaverryan
Copy link
Member

Hi!

This is a nice PR, but the issue is tricky: each plugin we add increases the download size of the controller. So, even if you aren't using the progress bar plugin, it will now be downloaded by the user (with Encore, it'll be packaged into the final built files & with asset mapper, the import will be followed and downloaded).

Instead, I think we should encourage people to create a small swup controller where they configure the exact behavior they want - so enhancing the docs here https://symfony.com/bundles/ux-swup/current/index.html#extend-the-default-behavior to show hooking up the progress bar would be 🙌 .

@yassinefikri
Copy link
Author

I agree, i also think that extending the controller will give easier access to customize the progress bar plugin options
i will update the PR as you mentioned

@yassinefikri yassinefikri changed the title [Swup] add progress bar plugin support add swup progress bar plugin to docs Aug 15, 2023
@weaverryan
Copy link
Member

Awesome - thank you Yassine!

@weaverryan weaverryan merged commit b2c00e6 into symfony:2.x Aug 15, 2023
34 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants