[LiveComponent] Only consider Live components in InterceptChildComponentRenderSubscriber #1097
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to the change of #1093.
Problem
The component stack now also contains embedded Components until they are fully rendered, which is good. But, that also means that with this setup
when re-rendering the
anotherLiveComponent
theInterceptChildComponentRenderSubscriber
would look at the parent component'schildrenFingerprints
to determine if it can short-circuit the rendering process foranotherLiveComponent
and return an empty html element causing the FE to not do a callback to re-render it. However since that parent is a non-live component it will never short-circuit.Solution
Only take live components into account.