[TwigComponent] Undefined var $name in ComponentExtension ?

[smnandre]

In TwigComponent/src/Twig/ComponentExtension, there is this method

    public function finishEmbeddedComponentRender(): void
    {
        try {
            $this->container->get(ComponentRenderer::class)->finishEmbeddedComponentRender();
        } catch (\Throwable $e) {
            $this->throwRuntimeError($name, $e);
        }
    }

I fear this won't work as $name is not defined... or am I missing something ?

[kbond]

Looks like a bug to me. Either we need to change the catch logic or or pass the name to the method. I don't know the context of this logic off the top of my head. @sneakyvv?

[smnandre]

Same thing @kbond :)

I'd code that, but i have no idea how to test that correctly, with LiveComponents, ...

    $compiler->write('$this->extensions[')
        ->string(ComponentExtension::class)
        ->raw(']->finishEmbeddedComponentRender(')
        ->string($this->getAttribute('component'))
        ->string(')')
        ->raw(";\n")
    ;

[kbond]

Did you hit this try...catch and get an \ArgumentCountError thrown?

[smnandre]

Hmm where ? Around this one or in throwRuntimeError ? Sorry i'm not sure how to handle that.. :|

[kbond]

I'm just wondering how you stumbled upon this bug. Just by looking at code or did an app actually run this and throw an exception.

(I'm trying to gauge how important it is to require the name here - can we just remove the try catch and let the caught exception be thrown as normal?)

[smnandre]

Reading code, and PhpStorm alerted me with some red wavy line :)

[smnandre]

I have to leave, i can try your solution in a couple of hours