New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Symfony 7 Support #1135
Add Symfony 7 Support #1135
Conversation
I think all asset mapper requirements can be updated with |
This is looking good, but when I check 2 random jobs - https://github.com/symfony/ux/actions/runs/6295950088/job/17090056239?pr=1135 and https://github.com/symfony/ux/actions/runs/6295950088/job/17090056789?pr=1135 the dependencies are still Symfony 6.4. What is blocking Symfony 7 from being installed on those jobs? It may be that some other dependency that we can't yet control is blocking us, but we should check and make sure the cause :) Thanks! |
At least some of the dependency issues are caused by zenstruck/foundry & zenstruck/browser. They both rely on upstream packages that do not yet support Symfony 7. I'll be working on this. |
Friendly ping @JoppeDC - there are a few conflicts now (probably easy). And if you can double-check why Symfony 7 isn't installed in those cases (as long as we know the reason and it's not "we're doing something wrong"), I'll be happy. |
I've resolved the conflicts. As for the 6.x installs, i've noticed they are blocked by a few packages. Mostly the zenstruck/* as mentioned above, but also some packages included in this update.
|
Although i notice that the StimulusBundle package still has a failing test. The |
FYI, zenstruck/browser & foundry should at least be installable with Symfony 7 now. |
Amazing @kbond , thanks a lot. Just tested locally on some of the packages, and it seems like its indeed resolving to 7.x now :) Will need to fix the StimulusBundle issue first and then i can verify in the new pipeline run that 7.x is installed :) |
Cool. I've got most issues resolved. There's still an issue related to the SecurityBundle, which i will have to check out further tomorrow. (We were using |
Let's drop support for 5.4 in Autocomplete and then use the new class. |
Thanks for your excellent work @JoppeDC! |
Update packages to allow Symfony 7
Changes done by this PR: