[TwigComponent] Fix configuration namespace end with "\" #1705

cavasinf · 2024-04-09T15:22:15Z

Q	A
Bug fix?	yes
New feature?	no
License	MIT

Fix the doc configuration about multi namespaces as the tree builder define.

ux/src/TwigComponent/src/DependencyInjection/TwigComponentExtension.php

Lines 157 to 159 in 0f8b952

    
           if (!str_ends_with($namespace, '\\')) { 
        
               throw new InvalidConfigurationException(sprintf('The twig_component.defaults namespace "%s" is invalid: it must end in a "\"', $namespace)); 
        
           }

smnandre

Yes, thank you!

kbond · 2024-04-09T17:55:39Z

Thank you @cavasinf.

Fix namespace end with "\"

1b2b111

carsonbot added the Status: Needs Review Needs to be reviewed label Apr 9, 2024

smnandre approved these changes Apr 9, 2024

View reviewed changes

carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Apr 9, 2024

kbond merged commit a3ce0ad into symfony:2.x Apr 9, 2024
1 check passed

cavasinf deleted the patch-1 branch April 9, 2024 18:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[TwigComponent] Fix configuration namespace end with "\" #1705

[TwigComponent] Fix configuration namespace end with "\" #1705

cavasinf commented Apr 9, 2024

smnandre left a comment

kbond commented Apr 9, 2024

	if (!str_ends_with($namespace, '\\')) {
	throw new InvalidConfigurationException(sprintf('The twig_component.defaults namespace "%s" is invalid: it must end in a "\"', $namespace));
	}

[TwigComponent] Fix configuration namespace end with "\" #1705

[TwigComponent] Fix configuration namespace end with "\" #1705

Conversation

cavasinf commented Apr 9, 2024

smnandre left a comment

Choose a reason for hiding this comment

kbond commented Apr 9, 2024