[LiveComponent] Fix array valued checkboxes change event handling #910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
welcoMattic
force-pushed
the
fix-array-values-checboxes
branch
from
273fcb7
to
b4ea936
Compare
weaverryan
reviewed
May 30, 2023
welcoMattic
force-pushed
the
fix-array-values-checboxes
branch
3 times, most recently
from
5dbe5d5
to
1fa766c
Compare
weaverryan
force-pushed
the
fix-array-values-checboxes
branch
from
1fa766c
to
0e94fec
Compare
|
Thank you Mathieu! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in the linked issue, the event
changeof checkboxes weren't fully triggered (it didn't trigger AJAX request). It was because of the always-equals values of the pre-checked value attribute of the element and the after-change-event value of the element.Thanks @Jim56450 for the help!