Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong path in manifest.json on windows #33

Closed
versh23 opened this issue Jun 19, 2017 · 4 comments
Closed

wrong path in manifest.json on windows #33

versh23 opened this issue Jun 19, 2017 · 4 comments

Comments

@versh23
Copy link

versh23 commented Jun 19, 2017

  "build/images\\icon-view.png": "/build/images/icon-view.png",
  "build/images\\logo-big-white.png": "/build/images/logo-big-white.png",

with that files JsonManifestVersionStrategy does not work correct

@versh23 versh23 changed the title wrong path in mainfest.json on windows wrong path in manifest.json on windows Jun 19, 2017
@weaverryan
Copy link
Member

Thanks for the report @versh23! I'll fix this in #28 so that the keys all use / instead of \\. Do all of the keys contain a \\ in them, or only the images?

@versh23
Copy link
Author

versh23 commented Jun 20, 2017

yes, only for images and fonts.

@weaverryan
Copy link
Member

Definitely will be fixed in #28 - I caught the exact issue and added a test case for it :)

@rtarnaud
Copy link

I'm still having issues with this. Unlike the OP, the \\ appears in the values of the manifest file, not in the keys. If I apply the same kind of fixes that you did in your PR, I am able to solve the issue. For example, line 95 of the manifest plugin file, change

memo[this.opts.basePath + key] = this.opts.publicPath + value;`

into

let val = this.opts.publicPath + value;
memo[this.opts.basePath + key] = val.replace(/\\/g, '/');

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants