Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moderate vulnerability in dependency yargs-parser #748

Closed
moay opened this issue May 7, 2020 · 2 comments · Fixed by #752
Closed

Moderate vulnerability in dependency yargs-parser #748

moay opened this issue May 7, 2020 · 2 comments · Fixed by #752

Comments

@moay
Copy link

moay commented May 7, 2020

Our CI just yelled at us, there is a vulnerability in yargs-parser. The vulnerability is patched, so maybe the patched version could be used?

Manual Review                                 │
│            Some vulnerabilities require your attention to resolve            │
│                                                                              │
│         Visit https://go.npm.me/audit-guide for additional guidance          │
└──────────────────────────────────────────────────────────────────────────────┘
┌───────────────┬──────────────────────────────────────────────────────────────┐
│ Low           │ Prototype Pollution                                          │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Package       │ yargs-parser                                                 │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Patched in    │ >=13.1.2 <14.0.0 || >=15.0.1 <16.0.0 || >=18.1.2             │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Dependency of │ @symfony/webpack-encore                                      │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Path          │ @symfony/webpack-encore > webpack-dev-server > yargs >       │
│               │ yargs-parser                                                 │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ More info     │ https://npmjs.com/advisories/1500                            │
└───────────────┴──────────────────────────────────────────────────────────────┘
┌───────────────┬──────────────────────────────────────────────────────────────┐
│ Low           │ Prototype Pollution                                          │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Package       │ yargs-parser                                                 │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Patched in    │ >=13.1.2 <14.0.0 || >=15.0.1 <16.0.0 || >=18.1.2             │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Dependency of │ @symfony/webpack-encore                                      │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Path          │ @symfony/webpack-encore > yargs-parser                       │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ More info     │ https://npmjs.com/advisories/1500                            │
└───────────────┴──────────────────────────────────────────────────────────────┘

Relevant part of the dependency tree:

├─┬ @symfony/webpack-encore@0.29.1
│ ├─┬ webpack-cli@3.3.11
│ │ └─┬ yargs@13.2.4
│ │   └── yargs-parser@13.1.2
│ ├─┬ webpack-dev-server@3.10.3
│ │ └─┬ yargs@12.0.5
│ │   └── yargs-parser@11.1.1
│ └── yargs-parser@12.0.0

The direct dependency is outdated as well as the dependency via webpack-dev-server. Both cannot be patched by using npm audit fix

@stof
Copy link
Member

stof commented May 7, 2020

For the webpack-dev-server dependency, this should be reported to https://github.com/webpack/webpack-dev-server

@stof
Copy link
Member

stof commented May 7, 2020

Actually, they already have a PR updating it at webpack/webpack-dev-server#2566

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants