drop symfony 4.4 support #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are there any strong reasons to drop 4.4 support? I see it's still maintained by Symfony until the end of 2022, and security fixes are available until the end of 2023. If there are no blockers - we probably could continue maintaining it |
weaverryan
previously approved these changes
Sep 7, 2022
There was a problem hiding this comment.
It's close enough now to the end of 4.4 support (November) that I am ok with dropping 4.4 support now. If these bundles required more active maintenance with a high likelihood of some critical bugs needing to be fixed for 4.4, I'd wait. But that seems unlikely :)
weaverryan
added
Status: Reviewed
jrushlow
force-pushed
the
feature/drop-4.4
branch
from
fe872f5
to
99746c0
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.