Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing target-language attr to all translations #121

Merged
merged 1 commit into from Jul 5, 2022
Merged

Add missing target-language attr to all translations #121

merged 1 commit into from Jul 5, 2022

Conversation

bocharsky-bw
Copy link
Member

Fixes #120

jrushlow
jrushlow approved these changes Jul 5, 2022
View reviewed changes
Copy link
Collaborator

@jrushlow jrushlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks @bocharsky-bw

@jrushlow jrushlow added the Feature New Feature label Jul 5, 2022
@jrushlow jrushlow merged commit 5dd56aa into SymfonyCasts:main Jul 5, 2022
@bocharsky-bw bocharsky-bw deleted the target-lang branch July 6, 2022 08:22
@jrushlow jrushlow added Bug Bug Fix and removed Feature New Feature labels Jul 12, 2022
@jrushlow jrushlow mentioned this pull request Jul 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrushlow jrushlow jrushlow approved these changes

Assignees
No one assigned
Labels
Bug Bug Fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[translations] ensure all translations have a target-language attribute
2 participants
@bocharsky-bw @jrushlow