Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove @trusted on dip1000 violation and fix code to please dmd #29

Open
nordlow opened this issue Sep 2, 2021 · 2 comments
Open

Remove @trusted on dip1000 violation and fix code to please dmd #29

nordlow opened this issue Sep 2, 2021 · 2 comments

Comments

@nordlow
Copy link
Contributor

nordlow commented Sep 2, 2021

as

source/concurrency/stoptoken.d(272,14): Error: reference to local variable `this` assigned to non-scope `cb.prev_`
@nordlow nordlow changed the title Building with dmd master errors dub test with dmd master errors Sep 2, 2021
@skoppe
Copy link
Collaborator

skoppe commented Sep 4, 2021

So it is this line it complains about

concurrency/source/concurrency/stoptoken.d

Line 272 in b655021

cb.prev_ = &head_;

@nordlow nordlow mentioned this issue Oct 12, 2021
Merged
@nordlow
Copy link
Contributor Author

nordlow commented Oct 12, 2021 •
edited

#33 currently wraps this in a @trusted call for now because lack of time. Changed the description of this issue.

@nordlow nordlow changed the title dub test with dmd master errors Remove @trusted on dip1000 violation Oct 12, 2021
@nordlow nordlow changed the title Remove @trusted on dip1000 violation Remove @trusted on dip1000 violation and fix code to please dmd Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nordlow @skoppe