Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make exported function private in source #55

Open
skoppe opened this issue Feb 21, 2022 · 0 comments
Open

make exported function private in source #55

skoppe opened this issue Feb 21, 2022 · 0 comments

Comments

@skoppe
Copy link
Collaborator

skoppe commented Feb 21, 2022

Because of dynamic library support we need to export 2 functions that allow us to sync the globalStopSource and the TLS localThreadExecutor across host/libraries.

However, that makes these functions accessible in source code. They are marked export which conflicts with private.

In the words of Martin Kinkelin:

In theory, we could make it private and embed an MSVC linker directive (pragma(linkerDirective, "/EXPORT:")) for the export (+ Linux export in dub.sdl).

That would still make the symbol loadable but at least not directly in source code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant