"sympa --health_check" should not attempt a database upgrade

[Cyrille37]

Version

• Sympa 6.2.40
• Perl 5.30.0
• Ubuntu 20.04 LTS (focal)

Installation method

apt install sympa

Expected behavior

sympa --health_check should report problems, not trying to repair the database.

Actual behavior

sympa --health_check send a email about database upgrade :

La structure de la base de données a été mise à jour ; consultez les journaux
pour plus de détails :

Field 'date_logs'  (table 'logs_table' ; database 'sympa') does NOT have awaited type (int(11)). Attempting to change it...
ALTER TABLE logs_table CHANGE date_logs date_logs int(11) 
Field date_logs in table logs_table, structure updated
Field 'usec_logs'  (table 'logs_table' ; database 'sympa') does NOT have awaited type (int(6)). Attempting to change it...
ALTER TABLE logs_table CHANGE usec_logs usec_logs int(6) 
Field usec_logs in table logs_table, structure updated
Field 'date_stat'  (table 'stat_table' ; database 'sympa') does NOT have awaited type (int(11)). Attempting to change it...
ALTER TABLE stat_table CHANGE date_stat date_stat int(11) 
Field date_stat in table stat_table, structure updated
Field 'date_session'  (table 'session_table' ; database 'sympa') does NOT have awaited type (int(11)). Attempting to change it...
ALTER TABLE session_table CHANGE date_session date_session int(11) 
Field date_session in table session_table, structure updated
Field 'hit_session'  (table 'session_table' ; database 'sympa') does NOT have awaited type (int(11)). Attempting to change it...
...
...

[racke]

Yes, a health check should certainly not trigger any changes, just report problems.

[ikedas]

Despite it's name, --health_check option is used to make database structure up-to-date.
Anyway, the PR I'll submit later to fix #1252 will fix the problem described here: The --health_check cannot really upgrade on MySQL 8.0.17 and later.

[ikedas]

I determine this to be a duplicate of #1252 and close it. If any objection, please request reopen.