Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sympa 6.2.67b.3 build failure #1326

Closed
dpc22 opened this issue Jan 18, 2022 · 9 comments · Fixed by #1332
Closed

Sympa 6.2.67b.3 build failure #1326

dpc22 opened this issue Jan 18, 2022 · 9 comments · Fixed by #1332
Labels
Milestone

Comments

@dpc22
Copy link
Contributor

dpc22 commented Jan 18, 2022

Version

Sympa 6.2.67b.3 from https://github.com/sympa-community/sympa/releases/download/6.2.67b.3/sympa-6.2.67b.3.tar.gz

Installation method

My own rpm, derived from official RHEL 7 rpm

Expected behavior

6.2.67b.3 should build

Actual behavior

"make check" fails with:

Test Summary Report
-------------------
t/Request_Handler_add+del.t (Wstat: 512 Tests: 1 Failed: 0)
  Non-zero exit status: 2
  Parse errors: No plan found in TAP output
Files=24, Tests=1205, 58 wallclock secs ( 0.19 usr  0.02 sys + 48.61 cusr  5.04 csys = 53.86 CPU)
Result: FAIL
Failed 1/24 test programs. 0/1205 subtests failed.

It is possible that this is a stupid error on my part and I am just missing a dependency. However I haven't run into this sort of build failure before. Maybe the following is significant?

#1299

That is the only mention of "make check" on https://github.com/sympa-community/sympa/blob/6.2.67b.3/NEWS.md

@ikedas
Copy link
Member

ikedas commented Jan 18, 2022

@dpc22, please try running:

cd (top of source tree)
./configure (options...)
make
PERL5LIB=src/lib:${PERL5LIB} /path/to/perl t/Request_Handler_add+del.t

@dpc22
Copy link
Contributor Author

dpc22 commented Jan 18, 2022

lists-2[dpc22:sympa-6.2.67b.3]$ PERL5LIB=src/lib:${PERL5LIB} /usr/bin/perl t/Request_Handler_add+del.t
ok 1 - add subscriber: List not open
Cannot create : No such file or directory at src/lib/Sympa/Spool/Outgoing.pm line 88.
# Tests were run but no plan was declared and done_testing() was not seen.

@ikedas
Copy link
Member

ikedas commented Jan 18, 2022

@dpc22,
Could you please change a file:

diff --git a/t/Request_Handler_add+del.t b/t/Request_Handler_add+del.t
index 7b0231e..feaa22a 100644
--- a/t/Request_Handler_add+del.t
+++ b/t/Request_Handler_add+del.t
@@ -86,7 +86,7 @@ open my $fh, '>', $Conf::Conf{etc} . '/data_sources/include_fi
 print $fh "include_file $tempdir/source\n";
 close $fh;

-Sympa::Log->instance->{level} = -1;
+#Sympa::Log->instance->{level} = -1;
 do {
     no warnings 'redefine';
     local (*Sympa::send_notify_to_listmaster) = sub {1};

and then retry?

@dpc22
Copy link
Contributor Author

dpc22 commented Jan 18, 2022

lists-2[dpc22:sympa-6.2.67b.3]$ PERL5LIB=src/lib:${PERL5LIB} /usr/bin/perl t/Request_Handler_add+del.t 2> ~/tmp/test.out
ok 1 - add subscriber: List not open

Plus a lot of output to stderr which may or may not be relevant, attached below:

stderr.txt

@ikedas
Copy link
Member

ikedas commented Jan 19, 2022

@dpc22, please check this patch. It'll be included in the next stable (6.2.68).

@dpc22
Copy link
Contributor Author

dpc22 commented Jan 19, 2022

Okay, that seems to have fixed the build problem. Thanks,

Are there any other showstopper bugs in 6.2.67b.3 which have been fixed in GIT?

I plan to kick the tires for day or two in expectation of 6.2.68.

@ikedas

This comment has been minimized.

@dpc22

This comment has been minimized.

@dpc22

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants