Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Primary auth.conf won't be used by robots #432

Closed
ikedas opened this issue Oct 9, 2018 · 3 comments · Fixed by #513
Closed

Primary auth.conf won't be used by robots #432

ikedas opened this issue Oct 9, 2018 · 3 comments · Fixed by #513
Assignees
Milestone

Comments

@ikedas
Copy link
Member

ikedas commented Oct 9, 2018

Version

At least 6.2.32 or later, and maybe also earlier versions.

Installation method

RPM, however other methods will apply.

Expected behavior

When these files exist (note: dom.ain below is not primary domain):

  • $SYSCONFDIR/auth.conf
  • $SYSCONFDIR/dom.ain/robot.conf

and this file does not exist:

  • $SYSCONFDIR/dom.ain/auth.conf

during login process on web interface of dom.ain, setting in the first file $SYSCONFDIR/auth.conf is applied.

Actual behavior

Setting in $SYSCONFDIR/auth.conf is not used but default behavior (only password login with user_table is enabled) is performed.

Additional information

Honestly I'm not sure current behavior is buggy. But it looks making sense that $SYSCONFDIR/auth.conf is used by default.

@ikedas ikedas added the bug label Oct 9, 2018
@ikedas ikedas added the design label Oct 19, 2018
@xavierba
Copy link
Contributor

xavierba commented Nov 7, 2018

It makes sense to have auth.conf behave like other conf/template files, that is, parse conf from narrower (in this case, mail domain) to wider (in this case, site) configuration, as described here : https://sympa-community.github.io/manual/customize/basics-configuration.html
I just spent a bit of time helping someone on IRC. There was no way to get LDAP auth working until an auth.conf file was dropped into /etc/sympa/mail_domain, although /etc/sympa/auth.conf was properly configured, but silently ignored.

@Saphar
Copy link

Saphar commented Nov 7, 2018

This bug also affects 6.2.24. I agree with xavierba, the behavior is unexpected and caused me quite some time to figure out.

@ikedas
Copy link
Member Author

ikedas commented Dec 26, 2018

Hi, could anyone please check if this patch will solve the problem?

@ikedas ikedas self-assigned this Dec 26, 2018
@ikedas ikedas added the ready A PR is waiting to be merged. Close to be solved label Jan 4, 2019
@ikedas ikedas removed the ready A PR is waiting to be merged. Close to be solved label Jan 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants