Misaligned legends in Duplicator

[nilshoerrmann]

This looks wrong:

[brendo]

Are you taking care of this one @nilshoerrmann?

[nilshoerrmann]

If anyone else around could fix this, that would be great.

[brendo]

What should happen? The legend line up with the left edge of the field?

Is this only noticeable on the DateTime field?

[nilshoerrmann]

It's a global issue – and yes the legend should line up.

[brendo]

Can you confirm if the above commit fixes the issue?

[brendo]

bump @nilshoerrmann

[nilshoerrmann]

I can't confirm yet, because I haven't tested it yet :p
But I will have a look at it soon.

[brendo]

Ty :)

[nilshoerrmann]

There still seem to be issues with the fieldset – I will have a look at it now.

[brendo]

I'm curious as how you are testing this?

I've been using the DateTime field on the Section Editor

[nilshoerrmann]

I'm changing the markup in the Webkit inspector and I the legend is a few pixels off for me (to the left).

[brendo]

Must be a difference between Firefox and Webkit then ;)

edit, indeed it is. padding: .5em; fixes Webkit, but indents Firefox. padding-left: 0 pulls the Webkit indent back, but in Firefox it aligns. Fun times!

[nilshoerrmann]

Only if Firefox doesn't apply the margin-left: -0.5em definition in admin.css ;)

[brendo]

Yet margin-left: -0.5em is required for Webkit's fix. Haha

[brendo]

Setting padding: 0; margin: 0 actually seems to resolve it in both Firefox and Webkit

[nilshoerrmann]

No, no! We need the margin in the preferences. It should be padding-left: 0.5em, see: 6e98ff4#L0R381

[brendo]

Setting padding-left: 0.5em will resolve the alignment issue in Webkit, but it will break the alignment in Firefox.

You mentioned removing margin-left: -0.5em will fix Firefox, but doing this then breaks Webkit again.

Heh, I'm confused.

[nilshoerrmann]

Damn. We should deprecate the usage of Firefox in connection with Symphony. I only know of a single developer using it …

[brendo]

Where is that margin required for Preferences? From what I can see legends on the Preferences page are absolutely positioned and won't be affected by this change as we are only applying it from within .collapsible context?

[nilshoerrmann]

You are right, it was required but has since been changed.

The problematic rule is fieldset.settings fieldset legend on line 338 of admin.css. But I think we can safely remove margin and padding settings there.

[brendo]

Looks like it! Teamwork. Thanks :)

[nilshoerrmann]

:)