Select box displays incorrectly in section editor

[tonyarnold]

This became apparent after 4ea2b21 was committed.

[brendo]

Also occurs with the Taglist field. Appears the last input has a bottom margin which pushes out a difference.

/cc @nilshoerrmann

[nilshoerrmann]

Without testing, this looks like an uncleared float.

[brendo]

Do we have a clearfix type class? The bottom line has a class of column meta

[brendo]

But yes, a clearfix style class does solve this issue, shall I add one? I noticed there is a the 'clearfix' added to frame:after, but adding frame in this situation causes undesirable effects

edit no, scratch that, the reason adding .frame works is because it kills the last margin-bottom declaration and replaces it with a padding-bottom.

[nilshoerrmann]

I'm not fond of a general clearfix class, we should handle this individually. .content needs to be cleared, using .content:after.

[brendo]

This fixes it, .meta {padding-bottom: 15px; margin-bottom: 0;}, but my question is, what should meta be replaced with now in 2.3?

[brendo]

Or this:

.frame > ol > li > div:first-of-type,
.frame > ul > li > div:first-of-type {
    padding: 10px 10px 0.1px 10px;
}

Which is strange, notice the 0.1px

[nilshoerrmann]

I'm not sure what .meta was for in 2.2 – it doesn't exist in 2.3.

The Page Select Box seems to use old markup. Following the example of the core fields the last two options should be set in a two column grid.

.frame > ol > li > div:first-of-type

This will always be .content.

[brendo]

The Page Select Box seems to use old markup. Following the example of the core fields the last two options should be set in a two column grid.

Not entirely correct, the Taglist and Select Box field use .meta classes. Infact the meta class is added by default by Field->appendShowColumnCheckbox. If this can be removed, sweet.

This will always be .content.

Those rules already existed. Can they be condensed then (rolled into the ones below on first look).

I think adding 0.1px would be useful as a migration crutch for extension developers.

[nilshoerrmann]

If this can be removed, sweet.

I think it can be removed.

Can they be condensed then (rolled into the ones below on first look).

Seems like it.

I think adding 0.1px would be useful as a migration crutch for extension developers.

If it works, why not. I looks a bit strange though.