Push deprecated warnings to log #2701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've logged all method calls. Defines are pretty hard to catch, so it's a can't do. I've also fixed some docs along the way. Fixes symphonycms#2693
brendo
reviewed
Jun 6, 2017
| * If `$writeToLog` is passed, this function will return boolean, otherwise | ||
| * void | ||
| */ | ||
| public function pushDeprecateWarningToLog($method, $alternative = null, array $opts = array()) |
There was a problem hiding this comment.
This is nice, only thing I can think of adding would be the removed version (if applicable). eg. The method blahis deprecated and will be removed in v3.0.0. Please usefoo instead.
michael-e
previously approved these changes
Jun 6, 2017
As suggested by @brendo
brendo
approved these changes
Jun 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've logged all method calls. Defines are pretty hard to catch, so it's
a can't do. I've also fixed some docs along the way.
Fixes #2693
It also adds stack trace info in deprecate message