Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transliterations are broken for parentheses #2890

Closed
michael-e opened this issue Mar 3, 2019 · 3 comments
Closed

Transliterations are broken for parentheses #2890

michael-e opened this issue Mar 3, 2019 · 3 comments
Assignees
@michael-e
Labels
1 - Minor Fix found Fixed in 2.7.x PR Submitted
Milestone
2.7.8

Comments

@michael-e
Copy link
Member

Affected Symphony version(s) : 2.7+
PHP version(s) : all
OS(es) : all

It is almost unbelievable that we have not noticed this very old bug before. It was introduced by @brendo in 2011: 6983d12

Transliterations don't work for parentheses — ( and ).

If you, for example, create a section called Hello (World), the handle will be hello-(world).

I will send a PR.
@michael-e michael-e self-assigned this Mar 3, 2019
michael-e added a commit to michael-e/symphony-2 that referenced this issue Mar 3, 2019
@michael-e
Fix transliterations for parentheses
97fdf07 
Fixes symphonycms#2890
@michael-e michael-e mentioned this issue Mar 3, 2019
Merged
@brendo
Copy link
Member

brendo commented Mar 3, 2019 •
edited
Loading

Wow 😮

Is the fix to remove the leading \ from those keys?

@michael-e
Copy link
Member Author

Yep. You simply missed to remove the escaping \.

@nitriques
Copy link
Member

wow !

@nitriques nitriques added this to the 2.7.8 milestone Mar 7, 2019
@cylkee cylkee mentioned this issue Apr 25, 2019
Closed
animaux added a commit to animaux/lang_german that referenced this issue Apr 25, 2019
@animaux
Fix for transliteration bug symphonycms/symphonycms#2890
a4d8f79
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michael-e michael-e

Labels
1 - Minor Fix found Fixed in 2.7.x PR Submitted
Projects
None yet
Milestone
2.7.8
Development

No branches or pull requests
3 participants
@michael-e @brendo @nitriques