Configuration cleanup

[brendo]

2.3 is probably a decent time to do a configuration cleanup to remove some of the unnecessary values.

This is a list of ones that I think can be removed, comments/additions welcome!

• allow_page_subscription - Set to 1 by default, if this is set to 0 it prevents extensions from 'hearing' any delegate notifications
• strict_error_handling - Originally added for backwards compatibility with pre 2.2 sites with the introduction of raising E_WARNING to exceptions in 2.2.
• character_set, character_encoding, runtime_character_set_alter - Used by the MySQL class to set the encoding to the defined values if runtime_character_set_alter is set to true. These values can't be changed anywhere except for the config. We advocate using utf8 (see Core fields don't set CHARSET and COLLATION when creating MySQL tables #743), so I think we should just force it. I can't see a reason why someone would choose to use something different?

[designermonkey]

From personal experience, leaving something like the character set stuff in would be helpful to people who are going to be using a pre-existing database that they have no control over the collation for.

I'm open to opinion on the likelihood of this though, but I think it's one that we should leave alone until at least version 3.

[brendo]

The thing is we don't use the configuration values when creating new tables, we always use utf8. How real is a case where utf8 isn't available? We require MySQL 5.0 now and from what I can see that always comes with unicode support

[nils-werner]

I'm currently working on this in my configcleanup branch.

[nils-werner]

@brendo what version number should version_compare compare to?

[brendo]

2.3dev, I changed it from 2.3pre earlier this afternoon as it seems to throw off version_compare even though the manual says otherwise.

[brendo]

Is this sweet to pull in?

PS: Try using git rebase integration from your branch if you just want to keep it up to date with the latest integration branch. This command will pop off your changes, apply all the integration commits to your branch and then apply all your changes over the top of the branch again. It lets your commit 'stay at the top' instead of getting buried. Handy command I only discovered the other day!

[nils-werner]

But I can't do so after pushing to a remote, right?

[nils-werner]

See pullrequest #771

[brendo]

But I can't do so after pushing to a remote, right?

Not sure, I don't think it'll have an effect in this case because the branch has already been updated.

[nils-werner]

FYI: I've delete the branch on GitHub using git push origin :configcleanup. Afterwards, I simply recreated the rebased branch by pushing to it.

[brendo]

Oh nice! Glad it worked :D