Fix indentation of Dynamic Data Sources to be consistent

[nilshoerrmann]

Dynamic data sources are not correctly indented. I guess this is because the external XML is appended as value and not converted to an internal XML object.

Nevertheless, the wrong indentation makes the XML hard to read in debug mode.

[michael-e]

We must be careful with this. Up to now dynamic datasources will even load badly formatted (i.e. invalid) RSS feeds like Facebook feeds (and somehow "repair" certain problems).

I don't know about the inner workings though.

[nilshoerrmann]

We must be careful with indentation or with handling external data at all? Not sure about your position here …

[michael-e]

I don't remember exactly, unfortunately. Once upon a time I had severe problems reading RSS feeds from Facebook as XML (in custom scripts) and decided to use dynamic datasources and output Symphony pages (then read those pages in custom scripts to further parse the content).

[simoneeconomo]

Perhaps if perfomance is the problem, we could put a checkbox in the DS editor that enables/disables indentation. Would that make sense?

[brendo]

Minor issue IMO, needs a test case.

[nilshoerrmann]

What kind of test case do you need? – It happens for all dynamic data source that I create.

[brendo]

Just a sample URL & screenshot should do it :)

[nickdunn]

Should this go into the debug devkit tracker? Sounds like a problem with Bitter.

[brendo]

I think so, it's the result of this commit, which speeds up the page and prevents the devkit from crashing with some XML.

I think Bitter definitely needs some TLC, last I remember @rowan-lewis was looking at http://pygments.org/ (Github's syntax highlighter)