Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regexp for 'documents' should also support docx #790

Closed
kanduvisla opened this issue Sep 29, 2011 · 6 comments
Closed

Regexp for 'documents' should also support docx #790

kanduvisla opened this issue Sep 29, 2011 · 6 comments

Comments

@kanduvisla
Copy link
Contributor

Now the regexp for 'documents' is:

/\.(?:doc|pdf|rtf|txt)$/i

but this should be:

/\.(?:doc|docx|pdf|rtf|txt)$/i

(perhaps there are also some more filetypes to add to this regexp?

@michael-e
Copy link
Member

Isn't it rather simple to add new doctypes? So why should we bloat the default? (Most if the time I even reduce it to only accept PDF.)

@designermonkey
Copy link
Member

I agree Michael. I can see why adding to the default would be nice, to avoid repetitive typing, but it's not a big requirement IMO.

@nickdunn
Copy link
Contributor

nickdunn commented Oct 3, 2011

Because doc is now esdentially deprecated and has been superseded by docx. I don't consider this bloat at all...it makes it more useful. Smart defaults make for an easier life.

@nickdunn
Copy link
Contributor

nickdunn commented Oct 3, 2011

Not a big requirement but I think a requirement nevertheless.

@michael-e
Copy link
Member

Well, OK then! If you like it, let's do it.

@nickdunn
Copy link
Contributor

nickdunn commented Oct 3, 2011

Pull request sent. Included in this commit.

@brendo brendo closed this as completed in f0a2c42 Oct 4, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants