New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breadcrumbs: parent page not linked #929
Comments
I swear I've fixed this and @eKoeS tweaked it to make the behaviour more intuitive as well. Perhaps there has been a merge regression somewhere |
Can you confirm the issue? Just want to make sure it's not my fork that is messed up ... |
Ah, I can confirm it. If the |
@eKoeS, can you remember why we explicitly made it this way? edit Ah, right! If the nesting setting is off, you can't filter the pages by Your original issue is a bit different though, you want the edit page in the breadcrumb. I think we should:
|
Sorry guys, I just woke up :)
To clarify: the idea was not to use links when nesting if off because it would completely alters the breadcrumbs behaviour. |
How would it alter the behaviour? I see the parent page in the breadcrumbs but I cannot click it – that just feels wrong. |
When nesting is on the parent page is a link to an Index view, while when it's off it's a link to an Edit view. I don't like this behaviour because we never link to Edit views in breadcrumbs, that task should be achieved by buttons (e.g. "Edit Configuration"). |
This sounds wrong to me. |
It's very logical to me: it allows you to see a filtered view of Pages belonging to that parent (which is only available when Consider this example:
Following your logic, "Sections" would link to the Edit page for that section, but that's wrong in my opinion: the parent level link should always take you to a list of available children. At least that's what I got used to by navigating breadcrumbs in other websites. This is also what happens |
We have this:
While
Pages
is linked to the overview,Parent Page
is not linked to anything.Why isn't it linked to the parent page edit view?
The text was updated successfully, but these errors were encountered: