Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breadcrumbs: parent page not linked #929

Closed
nilshoerrmann opened this issue Dec 7, 2011 · 9 comments
Closed

Breadcrumbs: parent page not linked #929

nilshoerrmann opened this issue Dec 7, 2011 · 9 comments

Comments

@nilshoerrmann
Copy link
Contributor

We have this:

Pages > Parent Page > Child Page

While Pages is linked to the overview, Parent Page is not linked to anything.
Why isn't it linked to the parent page edit view?

@brendo
Copy link
Member

brendo commented Dec 8, 2011

I swear I've fixed this and @eKoeS tweaked it to make the behaviour more intuitive as well. Perhaps there has been a merge regression somewhere

@nilshoerrmann
Copy link
Contributor Author

Can you confirm the issue? Just want to make sure it's not my fork that is messed up ...

@brendo
Copy link
Member

brendo commented Dec 8, 2011

Ah, I can confirm it. If the pages_table_nest_children is set to no, then the bug occurs.

@brendo
Copy link
Member

brendo commented Dec 8, 2011

@eKoeS, can you remember why we explicitly made it this way?

edit Ah, right! If the nesting setting is off, you can't filter the pages by ?parent=66 to show pages at that level, so that's why it removed.

Your original issue is a bit different though, you want the edit page in the breadcrumb.

I think we should:

  • If viewing the Editor, the breadcrumbs should relate to the Edit pages
  • If nesting is on, and you are on the index, breadcrumbs should filter the index page.

@brendo brendo closed this as completed in 4e44a06 Dec 8, 2011
@simoneeconomo
Copy link
Contributor

Sorry guys, I just woke up :)

If viewing the Editor, the breadcrumbs should relate to the Edit pages

To clarify: the idea was not to use links when nesting if off because it would completely alters the breadcrumbs behaviour.

@nilshoerrmann
Copy link
Contributor Author

How would it alter the behaviour? I see the parent page in the breadcrumbs but I cannot click it – that just feels wrong.

@simoneeconomo
Copy link
Contributor

When nesting is on the parent page is a link to an Index view, while when it's off it's a link to an Edit view. I don't like this behaviour because we never link to Edit views in breadcrumbs, that task should be achieved by buttons (e.g. "Edit Configuration").

@nilshoerrmann
Copy link
Contributor Author

When nesting is on the parent page is a link to an Index view

This sounds wrong to me.

@simoneeconomo
Copy link
Contributor

It's very logical to me: it allows you to see a filtered view of Pages belonging to that parent (which is only available when
nesting is on) and complies with the conventional purpose of breadcrumbs to drive you from particular (right), to general (left).

Consider this example:

Sections › Categories

Following your logic, "Sections" would link to the Edit page for that section, but that's wrong in my opinion: the parent level link should always take you to a list of available children. At least that's what I got used to by navigating breadcrumbs in other websites.

This is also what happens

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants