Notices #1566
Merged
Notices #1566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ergh, wait... There are a few submodule hiccups still... |
|
Alright, I've posted two PRs to the respective repositories: Please note that these repositories have not been rebased as they're in fact @allen 's. |
|
Could you kindly rebase this? I'd love to get a beta out this week and would like to start testing these changes ASAP |
…eConfiguration() and initialiseLog()
…remove the strict notice that the function should be applied on a non referenced object
…n-instantiated class. Instead, used reflection.
|
Ok, done. |
|
LETS DO THIS! |
brendo
added a commit
that referenced
this pull request
Dec 18, 2012
Correcting notices and warnings for the greater good of man. RE: #1041
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the cleaned up
noticesbranch from my repo in wich Allen and I tried to get rid of as manyE_NOTICEs as possible. Although I might have started, It's 99% Allen's work so all credit goes to him.Also notice the name of the branch: It's following the Linux Kernel's tradition of naming branches
for-linus. :-DOh and if anybody is curious how I dropped the two commits the way I was talking about it earlier: An interactive rebase:
will open the list of commits you're going to be rebasing in an editor. Remove any of those lines from the file and that particular commit will not be picked. Like the inverse of a
cherry-pick.