Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 5.2 compatibility fixes #1829

Closed
wants to merge 3 commits into from
Closed

PHP 5.2 compatibility fixes #1829

wants to merge 3 commits into from

Conversation

siimsoni
Copy link
Contributor

No description provided.

@iwyg
Copy link
Contributor

iwyg commented Sep 25, 2013

Instead of version php comparison, you could just check if the function exists. Don't know which one is better, but I'd prefer feature testing over version sniffing.

@siimsoni
Copy link
Contributor Author

Good point. I will update to check if the function exists for header_remove() fallback, but the finfo_open() in 5.2 provided by PECL in not equivalent to finfo_open() in PHP 5.3.

@designermonkey
Copy link
Member

I was under the impression we didn't support 5.2 any more? @brendo?

@iwyg
Copy link
Contributor

iwyg commented Sep 25, 2013

If the website's still a valid resource for information, then "PHP 5.2 or above" is the min. requirement.

@brendo
Copy link
Member

brendo commented Sep 25, 2013

PHP5.2 is still supported for 2.3 :(

Thanks for the fixes @slimson. You may want to look at using this for your PHP 5.3 check though, just for consistency everywhere else where do a version check rather than a feature check :)

Also, this pull request needs to be made against integration, not master.

@brendo brendo closed this Sep 25, 2013
@brendo brendo mentioned this pull request Dec 4, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants