Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds ability to output Author field as parameter with authors ids #988

Closed
wants to merge 1 commit into from
Closed

Conversation

a-ntoine
Copy link

I'm not sure about the getParameterPoolValue part, but it worked for what I needed.

@nils-werner
Copy link
Contributor

To the person merging this in: Please note that this PR is supposed to go into integration, please do not use the big, green "merge pull request" button.

I suggest this branch is being rebased and merge --no-ffed afterwards instead of doing a plain merge.

@a-ntoine Welcome abord, glad to see you posting pullrequests! Just to explain what I was saying before: we are generally implementing features against the integration branch. Only once a new version has been released the master branch catches up to it. The pull-request you've submitted is basically asking for us to pull your change into the wrong branch but it doesn't matter much since your change merges fine against integration as well.

@a-ntoine
Copy link
Author

@nils-werner thanks for the explanation. I wasn't sure which branch to choose to be honest. I can always cancel this one and submit it again on the right branch if you prefer.

@brendo thanks for the tip, I will see how it works.

GitHub is a lot of fun!

@brendo
Copy link
Member

brendo commented Jan 12, 2012

GitHub is a lot of fun!

Sure is!

@nils-werner
Copy link
Contributor

Wow, I should learn how to read. I just came up with the exact same code because of a question on the forums...

@nils-werner
Copy link
Contributor

Also, I will close this PR. The Code can be simplified as brendan explained and the PR should go into integration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants