Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace pyglet as the default viewer in the preview() function #15680

Open
asmeurer opened this issue Dec 20, 2018 · 4 comments
Open

Replace pyglet as the default viewer in the preview() function #15680

asmeurer opened this issue Dec 20, 2018 · 4 comments
Labels

Comments

@asmeurer
Copy link
Member

Right now preview() by default uses pyglet to show the image. I think it would be better to have a more portable default. Some possibilities are the PIL show function, which opens the image in the default image viewer for the platform, or using matplotlib.imshow. Probably both should be supported and the default would try each until it finds the best one that works. We can leave the pyglet viewer there, but not as the default.

@asmeurer
Copy link
Member Author

I guess the change of the default should be discussed, but we should add PIL and matplotlib as viewers regardless.

@avishrivastava11
Copy link
Contributor

avishrivastava11 commented Dec 25, 2018

@asmeurer +1 for the default image viewer. Although I'm not sure about using the matplotlib.imshow because of two reasons

  1. Its slower than the default image viewer, and also slower to navigate (Or could only be happening in my system; If its so, please let me know)
  2. It might have compatibility issues on certain systems where they don't have a certain software installed (I might be wrong here; If so, please correct me)

But I'm unaware of the method to find the default viewer and use that. Could you help me here (as I would like to take up this issue)?

@oscarbenjamin
Copy link
Contributor

I have a proof of concept for using matplotlib.figshow instead of pyglet here: #8446 (comment)

@asmeurer
Copy link
Member Author

asmeurer commented Nov 9, 2023

We should use the system viewer as the default. There's already code there for it (#19867), so we just need to change the default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants