Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doctest added to property not tested #17402

Open
oscarbenjamin opened this issue Aug 13, 2019 · 0 comments
Open

Doctest added to property not tested #17402

oscarbenjamin opened this issue Aug 13, 2019 · 0 comments
Labels
matrices Testing Related to the test runner. Do not use for test failures unless it relates to the test runner itself

Comments

@oscarbenjamin
Copy link
Contributor

This doctest should fail:

>>> A = Matrix([[1, 2], [2, 1]])
>>> A.is_positive_definite
False
>>> A.is_positive_semidefinite
False
>>> A.is_negative_definite
True

It does fail under pytest but may be it is ignored by the internal doctest runner.

I think it's because of this:

is_negative_definite = \
property(fget=is_negative_definite, doc=_doc_positive_definite)

I am not really sure what idea is with this docstring. How would a user access it anyway?

@oscarbenjamin oscarbenjamin added matrices Testing Related to the test runner. Do not use for test failures unless it relates to the test runner itself labels Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
matrices Testing Related to the test runner. Do not use for test failures unless it relates to the test runner itself
Projects
None yet
Development

No branches or pull requests

1 participant