Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate max_degrees and get_upper_degree() in DixonResultant #17763

Open
ctsiagkalis opened this issue Oct 20, 2019 · 3 comments
Open

Deprecate max_degrees and get_upper_degree() in DixonResultant #17763

ctsiagkalis opened this issue Oct 20, 2019 · 3 comments
Labels
Deprecation Removal Tracks the removal of a deprecated feature. See github.com/sympy/sympy/wiki/Deprecating-policy polys

Comments

@ctsiagkalis
Copy link
Contributor

More information in #17749
@ctsiagkalis ctsiagkalis changed the title Deprecate max_degrees and `get_upper_degree() in DixonResultant Deprecate max_degrees and get_upper_degree() in DixonResultant Oct 20, 2019
@jksuom jksuom added the Deprecation Removal Tracks the removal of a deprecated feature. See github.com/sympy/sympy/wiki/Deprecating-policy label Oct 20, 2019
@asmeurer
Copy link
Member

I'm trying to update this deprecation as part of #22900 but I'm a bit confused. It says that get_upper_degree() should be replaced with get_max_degrees(), but the latter takes an argument. How would one replace max_degrees and get_upper_degree()`? Or should they simply not be used at all?

@asmeurer
Copy link
Member

CC @jksuom

@oscarbenjamin
Copy link
Contributor

I don't understand why DixonResultant isn't just a function like dixon_resultant e.g.:
https://resources.wolframcloud.com/FunctionRepository/resources/DixonResultant/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Deprecation Removal Tracks the removal of a deprecated feature. See github.com/sympy/sympy/wiki/Deprecating-policy polys
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@asmeurer @oscarbenjamin @jksuom @ctsiagkalis