Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transient test error in simplify/tests/test_hyperexpand.py #18447

Open
tom-pytel opened this issue Jan 24, 2020 · 2 comments
Open

Transient test error in simplify/tests/test_hyperexpand.py #18447

tom-pytel opened this issue Jan 24, 2020 · 2 comments
Labels
polys simplify Testing Related to the test runner. Do not use for test failures unless it relates to the test runner itself

Comments

@tom-pytel
Copy link
Contributor

Recently a commit which had nothing to do with this functionality failed for me with:

sympy/simplify/tests/test_hyperexpand.py:test_partial_simp
...
sympy.polys.polyerrors.PolynomialDivisionFailed: couldn't reduce degree in a polynomial division
algorithm when dividing [EX(2500), EX(0)] by [EX((29 - 420*I)*(29 + 420*I)/177241)]. This can
happen when it's not possible to detect zero in the coefficient domain. The domain of computation
is EX. You may want to use a different simplification algorithm. Note that in general it's not possible
to guarantee to detect zero in this domain.

Running the test again with no changes succeeded. Is this a randomized test which just happened to catch a bug or an invalid generated input?

@jksuom
Copy link
Member

jksuom commented Jan 24, 2020

This looks like the same issue as here.

@tom-pytel
Copy link
Contributor Author

tom-pytel commented Jan 24, 2020

This looks like the same issue as here.

So it is a known issue, in which case apart from that is it a good idea to have:

def test_partial_simp():
    # First test that hypergeometric function formulae work.
    a, b, c, d, e = (randcplx() for _ in range(5))

in what should in theory be a deterministic test (since it can sometimes trigger this issue)?

@oscarbenjamin oscarbenjamin added polys Testing Related to the test runner. Do not use for test failures unless it relates to the test runner itself simplify labels Jan 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
polys simplify Testing Related to the test runner. Do not use for test failures unless it relates to the test runner itself
Projects
None yet
Development

No branches or pull requests

3 participants