Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation of compute_leading_term #21843

Open
0sidharth opened this issue Aug 9, 2021 · 0 comments
Open

Deprecation of compute_leading_term #21843

0sidharth opened this issue Aug 9, 2021 · 0 comments
Labels
Deprecation Removal Tracks the removal of a deprecated feature. See github.com/sympy/sympy/wiki/Deprecating-policy series

Comments

@0sidharth
Copy link
Member

The compute_leading_term method is being deprecated in #21837. as_leading_term can be used instead.

The individual _eval_as_leading_term methods are quite cheap, some of them involve a call to limit, but that is generally on trivial args and would not take much time. compute_leading_term calculates series first (which itself would be relatively expensive if the arg of the function is not trivial), and then calls as_leading_term.
The possible simplification of the argument of the function to its series expansion (which itself could be slow in the same cases _eval_as_leading_term is slow due to the limit call), does not give any visible speed improvements over directly calling as_leading_term, so this method is no longer needed. It was used at 2 places in the codebase, which have been changed.

This is also the deprecation removal tracking issue.

@oscarbenjamin oscarbenjamin added Deprecation Removal Tracks the removal of a deprecated feature. See github.com/sympy/sympy/wiki/Deprecating-policy series labels Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deprecation Removal Tracks the removal of a deprecated feature. See github.com/sympy/sympy/wiki/Deprecating-policy series
Projects
None yet
Development

No branches or pull requests

2 participants