Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Current tests can fail depending on terminal width #22399

Open
ThePauliPrinciple opened this issue Oct 31, 2021 · 0 comments
Open

Current tests can fail depending on terminal width #22399

ThePauliPrinciple opened this issue Oct 31, 2021 · 0 comments
Labels
interactive Testing Related to the test runner. Do not use for test failures unless it relates to the test runner itself

Comments

@ThePauliPrinciple
Copy link
Contributor

To my surprise, today as I was testing a branch, it failed in the pretty printer tests. Since I had not touched those files, I reverted to the master branch and still had this issue.

It turns out that when I have my terminal on full screen, a test is failed because it is expected to contain a newline, but it does not have it. Indeed, that output fits on one line:
afbeelding

While I appreciate that my screen might be a bit larger than average, I would argue that it is not a completely unreasonable resolution to work at. The issue might be related to working with Ubuntu on WSL2.

Making my terminal smaller indeed solves the failed test.
@oscarbenjamin oscarbenjamin added interactive Testing Related to the test runner. Do not use for test failures unless it relates to the test runner itself labels Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
interactive Testing Related to the test runner. Do not use for test failures unless it relates to the test runner itself
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@oscarbenjamin @ThePauliPrinciple