Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI checks failing due to timeout on slow 2 test #24005

Closed
tjstienstra opened this issue Sep 2, 2022 · 5 comments
Closed

CI checks failing due to timeout on slow 2 test #24005

tjstienstra opened this issue Sep 2, 2022 · 5 comments

Comments

@tjstienstra
Copy link
Contributor

In the PR #23982 the CI checks failed due to the slow 2 test running for too long, while this test should not have been affected in the PR. The only difference between success or failing of this test seems to be the choice of random seed. The link to the failed test is https://github.com/sympy/sympy/runs/8130779043?check_suite_focus=true

@oscarbenjamin
Copy link
Contributor

Can you reproduce the problem by setting the random seed?

@tjstienstra
Copy link
Contributor Author

@brocksam FYI

@tjstienstra
Copy link
Contributor Author

Tried to reproduce it using PYTHONHASHSEED=391990152 TRAVIS_BUILD_NUMBER=true bin/test --force-colors --slow --timeout=595 --split=2/2 --seed=35447760 in a VM and it passed within the time constraints. The settings also seem to be the same:

=========================================================================================== test process starts ===========================================================================================
executable:         /usr/bin/python  (3.10.4-final-0) [CPython]
architecture:       64-bit
cache:              yes
ground types:       python 
numpy:              None
random seed:        35447760
hash randomization: on (PYTHONHASHSEED=391990152)
split:              2/2

So the theory that the problem is caused by the choice of random seed, seems less likely. I will re-trigger the CI by force pushing the last commit again and see what is the result.

@tjstienstra
Copy link
Contributor Author

After re-triggering the CI the code did pass all tests: https://github.com/sympy/sympy/runs/8193143814?check_suite_focus=true

Shall I close this issue due to failing to reproduce the error and the fact that it can be solved by re-triggering the CI?

@oscarbenjamin
Copy link
Contributor

Yes, I'll close this. It is probably not useful to have an open issue for something that can't be reproduced.

It could be that the failure is due to an intermittent problem in CI. It might also be a genuine SymPy problem but without any way to investigate the problem the open issue isn't useful.

We can reopen this if it happens again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants