Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: exclude tests and rubi from wheel #24310

Open
eagleoflqj opened this issue Nov 26, 2022 · 2 comments
Open

RFC: exclude tests and rubi from wheel #24310

eagleoflqj opened this issue Nov 26, 2022 · 2 comments
Labels
RFC Request For Comments

Comments

@eagleoflqj
Copy link
Member

As we are planning to move to pytest, it may make sense to exclude sympy.test and all test files from binary wheel, as they provide no value to end users and contributes to wheel size.
Also, since rubi is broken, it shouldn't be included either.

@eagleoflqj eagleoflqj added the RFC Request For Comments label Nov 26, 2022
@oscarbenjamin
Copy link
Contributor

I agree on both counts.

For the tests I suggest putting them into a separate pypi project so that someone can do pip install sympy-tests. Also since #24291 proposes to add a sympy[tests] packaging extra the sympy-tests package could be added as a dependency of the extra.

For rubi it should just be developed outside of the sympy repo as a separate package at least until it works. For now I suggest just to delete rubi. It will still be there in the git history if anyone wants to extract it to a separate package.

@oscarbenjamin
Copy link
Contributor

It will still be there in the git history if anyone wants to extract it to a separate package.

Although if it is straight-forward to just extract it to a separate repo in the symp organisation then that would be better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFC Request For Comments
Projects
None yet
Development

No branches or pull requests

2 participants