You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Following #24395 I think the ring_series module should probably not use sparse polynomials with fractional exponents. I think that this is an abuse of the sparse polynomial data structures and should be changed. I suspect that this will regularly throw up bugs because the classes were not designed for this.
A proper implementation of a Puiseux series should be done differently perhaps more along the lines of the suggestion for Laurent polynomial rings in #5131. Every Puiseax series with rational exponents could be represented as a polynomial in some rational power of the generator e.g.:
x**(1/2) + 2*x**(3/2) = y + 2*y**3 where y = x**(1/2)
There should be a way to explicitly construct a Puiseux ring in which monomials can be raised to fractional and negative powers but the representation should internally use dense or sparse ordinary polynomials with natural exponents. If a Puiseax ring should include negative powers then my suggestion would be to implement Laurent polynomial rings on top of ordinary polynomial rings and then to implement Puiseux rings on top of Laurent rings.
Following #24395 I think the
ring_series
module should probably not use sparse polynomials with fractional exponents. I think that this is an abuse of the sparse polynomial data structures and should be changed. I suspect that this will regularly throw up bugs because the classes were not designed for this.There is some discussion of this in the docs:
https://docs.sympy.org/latest/modules/polys/ringseries.html
A proper implementation of a Puiseux series should be done differently perhaps more along the lines of the suggestion for Laurent polynomial rings in #5131. Every Puiseax series with rational exponents could be represented as a polynomial in some rational power of the generator e.g.:
There should be a way to explicitly construct a Puiseux ring in which monomials can be raised to fractional and negative powers but the representation should internally use dense or sparse ordinary polynomials with natural exponents. If a Puiseax ring should include negative powers then my suggestion would be to implement Laurent polynomial rings on top of ordinary polynomial rings and then to implement Puiseux rings on top of Laurent rings.
Relevant parts of the SAGE docs:
https://doc.sagemath.org/html/en/reference/power_series/sage/rings/puiseux_series_ring.html
https://doc.sagemath.org/html/en/reference/power_series/sage/rings/puiseux_series_ring_element.html
The text was updated successfully, but these errors were encountered: