New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding electron_rest_mass unit in physics.units #24463
Conversation
✅ Hi, I am the SymPy bot (v169). I'm here to help you write a release notes entry. Please read the guide on how to write release notes. Your release notes are in good order. Here is what the release notes will look like:
This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.12. Click here to see the pull request description that was parsed.
Update The release notes on the wiki have been updated. |
Benchmark results from GitHub Actions Lower numbers are good, higher numbers are bad. A ratio less than 1 Significantly changed benchmark results (PR vs master) Significantly changed benchmark results (master vs previous release) before after ratio
[41d90958] [cb037d69]
<sympy-1.11.1^0>
- 1.17±0ms 735±2μs 0.63 solve.TimeSparseSystem.time_linear_eq_to_matrix(10)
- 3.34±0.01ms 1.38±0ms 0.41 solve.TimeSparseSystem.time_linear_eq_to_matrix(20)
- 6.62±0.01ms 2.04±0.08ms 0.31 solve.TimeSparseSystem.time_linear_eq_to_matrix(30)
Full benchmark results can be found as artifacts in GitHub Actions |
Looks good to me. Not directly related to this PR, but it seems inconvenient to add more units. The same (as well as very similar) code needs to be added in different files. |
I also added an angstrom unit via #24425, what can I do with that |
Maybe it's a good idea to investigate which "common" units SymPy is missing and add them in the same PR. It would also be helpful if you can squash commits that are just typos. If you're not familiar with squashing in git, then make sure you make a hard backup (you're overriding the version control, so you can't rely on git to back up what you have done). |
There should be a release note for this |
Done! |
References to other Issues or PRs
Fixes #24462
Brief description of what is fixed or changed
The electron rest mass (symbol: me) is the mass of a stationary electron, also known as the invariant mass of the electron. It is one of the fundamental constants of physics.
Other comments
Release Notes