App crash while adding Nodes or Repos

[donpillo]

App crashes when pressing
"Add Node" or "Add Repo" or trying to open a already added Repo.

adding Nodes and Repos via the menu "Web GUI" works.

Android: 4.4.2
Samsung Note 8 - GT-N5110
Syncthing Android Version: 0.4.0 - 29.06.2014
Synthing Version: v0.8.17

[Nutomic]

Yep, got the report through Play Store.

Does this apk fix it?
https://dl.dropboxusercontent.com/u/22457329/syncthing-android-armeabi_v7a-issue-51.apk

Edit: Forget it, this doesn't work. Will upload a fixed apk later.

[Nutomic]

Ok try this one:
https://dl.dropboxusercontent.com/u/22457329/syncthing-android-armeabi_v7a-issue-51-2.apk

[firecat53]

I think I'm experiencing this same bug. To reproduce,

1. Force stop Syncthing and clear data and cache from the 'Apps' menu
2. Reboot
3. Reinstall Syncthing and start. Wait for keys to generate
4. Add repository. When you click the 'Restart needed' icon in the statusbar, Syncthing shows the 'Waiting for API' messages and stays there.
5. Kill process
6. Restart Syncthing...it will open for 5-10 seconds then show the 'Unfortunately, Syncthing has stopped' dialog. Can't restart again until phone is rebooted.

Logcat: https://github.com/firecat53/github_attachments/blob/master/syncthing_repo_add_crash.tar.gz

I also tried the exact same sequence with the 2nd APK you provided above with the same results.

Logcat: https://github.com/firecat53/github_attachments/blob/master/syncthing_repo_add_crash_test_apk.tar.gz

Let me know if this is the same issue or if we need to open a new ticket for this.

Thanks!
Scott

[Nutomic]

@firecat53 Both of your logs say "Syncthing binary returned error code 3". Have a look at #52 (reinstall/reboot).

[rkfg]

Same here on Nexus 10. Though it now launches, adding repo or node causes crash. Logcat points at your own code:

I/ActivityManager(  451): START u0 {act=create cmp=com.nutomic.syncthingandroid.debug/com.nutomic.syncthingandroid.gui.RepoSettingsActivity} from pid 1942
D/AndroidRuntime( 1942): Shutting down VM
W/dalvikvm( 1942): threadid=1: thread exiting with uncaught exception (group=0x41616ba8)
E/AndroidRuntime( 1942): FATAL EXCEPTION: main
E/AndroidRuntime( 1942): Process: com.nutomic.syncthingandroid.debug, PID: 1942
E/AndroidRuntime( 1942): java.lang.RuntimeException: Unable to start activity ComponentInfo{com.nutomic.syncthingandroid.debug/com.nutomic.syncthingandroid.gui.RepoSettingsActivity}: java.lan
g.IllegalStateException: ActionBarImpl can only be used with a compatible window decor layout
E/AndroidRuntime( 1942):        at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2184)
E/AndroidRuntime( 1942):        at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2233)
E/AndroidRuntime( 1942):        at android.app.ActivityThread.access$800(ActivityThread.java:135)
E/AndroidRuntime( 1942):        at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1196)
E/AndroidRuntime( 1942):        at android.os.Handler.dispatchMessage(Handler.java:102)
E/AndroidRuntime( 1942):        at android.os.Looper.loop(Looper.java:136)
E/AndroidRuntime( 1942):        at android.app.ActivityThread.main(ActivityThread.java:5001)
E/AndroidRuntime( 1942):        at java.lang.reflect.Method.invokeNative(Native Method)
E/AndroidRuntime( 1942):        at java.lang.reflect.Method.invoke(Method.java:515)
E/AndroidRuntime( 1942):        at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:785)
E/AndroidRuntime( 1942):        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:601)
E/AndroidRuntime( 1942):        at dalvik.system.NativeStart.main(Native Method)
E/AndroidRuntime( 1942): Caused by: java.lang.IllegalStateException: ActionBarImpl can only be used with a compatible window decor layout
E/AndroidRuntime( 1942):        at com.android.internal.app.ActionBarImpl.init(ActionBarImpl.java:193)
E/AndroidRuntime( 1942):        at com.android.internal.app.ActionBarImpl.<init>(ActionBarImpl.java:166)
E/AndroidRuntime( 1942):        at android.app.Activity.initActionBar(Activity.java:1912)
E/AndroidRuntime( 1942):        at android.app.Activity.getActionBar(Activity.java:1893)
E/AndroidRuntime( 1942):        at com.nutomic.syncthingandroid.gui.RepoSettingsActivity.onCreate(RepoSettingsActivity.java:89)
E/AndroidRuntime( 1942):        at android.app.Activity.performCreate(Activity.java:5231)
E/AndroidRuntime( 1942):        at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1087)
E/AndroidRuntime( 1942):        at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2148)
E/AndroidRuntime( 1942):        ... 11 more
W/ActivityManager(  451):   Force finishing activity com.nutomic.syncthingandroid.debug/com.nutomic.syncthingandroid.gui.RepoSettingsActivity
W/ActivityManager(  451):   Force finishing activity com.nutomic.syncthingandroid.debug/com.nutomic.syncthingandroid.gui.MainActivity
W/ActivityManager(  451): Activity pause timeout for ActivityRecord{4209d6b8 u0 com.nutomic.syncthingandroid.debug/com.nutomic.syncthingandroid.gui.RepoSettingsActivity t2 f}
D/mali_winsys(  709): new_window_surface returns 0x3000
I/Process ( 1942): Sending signal. PID: 1942 SIG: 9
I/ActivityManager(  451): Process com.nutomic.syncthingandroid.debug (pid 1942) has died.

[Nutomic]

@rkfg: Which apk/version were you using?

[rkfg]

The last one you posted here, https://dl.dropboxusercontent.com/u/22457329/syncthing-android-armeabi_v7a-issue-51-2.apk
After uninstalling it and installing the market version it crashes as in #52. Reboot "fixes" it but it's definitely not ok. Probably the previous version stays loaded for some reason and they conflict, I can't come up with better idea why reboot heals the crash.

Market version crashes as well on adding repo/node (the reason I'm writing here), but the trace is different:

E/AndroidRuntime( 2024): FATAL EXCEPTION: main
E/AndroidRuntime( 2024): Process: com.nutomic.syncthingandroid, PID: 2024
E/AndroidRuntime( 2024): java.lang.RuntimeException: Unable to start activity ComponentInfo{com.nutomic.syncthingandroid/com.nutomic.syncthingandroid.gui.RepoSettingsActivity}: java.lang.NullPointerException
E/AndroidRuntime( 2024):    at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2184)
E/AndroidRuntime( 2024):    at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2233)
E/AndroidRuntime( 2024):    at android.app.ActivityThread.access$800(ActivityThread.java:135)
E/AndroidRuntime( 2024):    at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1196)
E/AndroidRuntime( 2024):    at android.os.Handler.dispatchMessage(Handler.java:102)
E/AndroidRuntime( 2024):    at android.os.Looper.loop(Looper.java:136)
E/AndroidRuntime( 2024):    at android.app.ActivityThread.main(ActivityThread.java:5001)
E/AndroidRuntime( 2024):    at java.lang.reflect.Method.invokeNative(Native Method)
E/AndroidRuntime( 2024):    at java.lang.reflect.Method.invoke(Method.java:515)
E/AndroidRuntime( 2024):    at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:785)
E/AndroidRuntime( 2024):    at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:601)
E/AndroidRuntime( 2024):    at dalvik.system.NativeStart.main(Native Method)
E/AndroidRuntime( 2024): Caused by: java.lang.NullPointerException
E/AndroidRuntime( 2024):    at com.nutomic.syncthingandroid.gui.RepoSettingsActivity.onCreate(RepoSettingsActivity.java:89)
E/AndroidRuntime( 2024):    at android.app.Activity.performCreate(Activity.java:5231)
E/AndroidRuntime( 2024):    at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1087)
E/AndroidRuntime( 2024):    at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2148)
E/AndroidRuntime( 2024):    ... 11 more
W/ActivityManager(  450):   Force finishing activity com.nutomic.syncthingandroid/.gui.RepoSettingsActivity
W/ActivityManager(  450):   Force finishing activity com.nutomic.syncthingandroid/.gui.MainActivity

[Nutomic]

Okay, I did another approach and fixed it by making the repo/node settings fullscreen, instead of a dialog. This might not look as good (lots of empty space probably), but at least it works.

Maybe I can revisit this in the future