Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weird things happen when deleting just created files #2211

Closed
alednz opened this issue Aug 29, 2015 · 24 comments
Closed

Weird things happen when deleting just created files #2211

alednz opened this issue Aug 29, 2015 · 24 comments
Labels
bug A problem with current functionality, as opposed to missing functionality (enhancement) frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion

Comments

@alednz
Copy link

alednz commented Aug 29, 2015

During my activity, sometimes I delete just created files.

Now I have an "Out of Sync" with 26 items failed.

Every file is in "no such file or directory"

@AudriusButkevicius
Copy link
Member

A rescan on the node which dwleted them should fix it.

@alednz
Copy link
Author

alednz commented Aug 30, 2015 via email

@AudriusButkevicius
Copy link
Member

Do you have steps how to reproduce this reliably?

@alednz
Copy link
Author

alednz commented Aug 30, 2015 via email

@AudriusButkevicius
Copy link
Member

Can you actually reproduce it with the steps above?

@AudriusButkevicius
Copy link
Member

Also, restarting the originator node should fix this.

@alednz
Copy link
Author

alednz commented Aug 30, 2015 via email

@AudriusButkevicius
Copy link
Member

Is one of the nodes a master?

@alednz
Copy link
Author

alednz commented Aug 30, 2015 via email

@calmh
Copy link
Member

calmh commented Aug 30, 2015

Are you using a translated version and actually mean "master" when you say "originator"?

@alednz
Copy link
Author

alednz commented Aug 30, 2015 via email

@alednz
Copy link
Author

alednz commented Sep 6, 2015 via email

@bluewavenet
Copy link

I had this exact error between 2 linux systems. Syncthing was running as user. I copied files to the users sync folder as root, giving the user rw access via user group. User could rw the files but owner was root. Syncthing gave this message on the other device. I deleted the files again and error went away. Put them back and set file ownership as user and synced up ok. I did not give it a second thought afterwards....

@alednz
Copy link
Author

alednz commented Sep 15, 2015 via email

@graboluk
Copy link

I seem to have encountered the same issue (i.e. devices reporting "Out of Sync", and 0b files, after adding and immediately deleting files into ~/Sync).

I have st 0.11.25 installed on computers A, B, C (all debian testing). On A I add a folder "current" to ~/Sync with 40 Mb data. Then, after B and C start pulling, I realize it's a wrong folder, so I remove it. Finally (I'm not sure if this part is important for what follows), I add another file to ~/Sync on A.

Result is that all three machines report being "out of sync", and all three report the other two to be "up to date".

~/Sync on A looks the way it should look. ~/Sync on B and C have additionally folder "current" with files in it, but all files have size 0. Machine C keeps reporting (and presumably B as well, but I haven't figured out how to check it) mesasges of the sort:

[WUZ2F] 00:30:59 INFO: Puller (folder "default", dir "current/Dyson"): delete: remove /home/luke/Sync/current/Dyson: directory not empty

[WUZ2F] 00:30:59 INFO: Puller (folder "default", dir "current"): delete: remove /home/luke/Sync/current: directory not empty

[WUZ2F] 00:30:59 INFO: Folder "default" isn't making progress. Pausing puller for 1m0s.

then it pauses for 1m and repeats reporting the same messages.

If now I add files to ~/Sync on either A, B, or C, they seem to be syncing fine (although all three still report that they are out of sync and that other two machiens are up to date).

Addendum: 1) when I removed the folders "current" from B and C, then all three machines, without restarting st, report being up to date (and report both other machines being up to date).
2) I've reproduced it in 2 out of 6 runs with steps from the second paragraph.

@bluewavenet
Copy link

Reproducible 100% on a slow link. Not sure it is a bug as such - better than immediately deleted folders coming back I suppose. Fixed on the fly by addendum 1. There is possibly some logic to prevent this happening. Only happens when a folder is deleted before it is synced.

@calmh calmh added the bug A problem with current functionality, as opposed to missing functionality (enhancement) label Nov 19, 2015
@calmh calmh changed the title Sync missing files Weird things happen when deleting just created files Nov 19, 2015
@calmh calmh added this to the Unplanned milestone Jan 1, 2016
@phene
Copy link

phene commented May 1, 2016

I have also noticed that if I use syncthing to transfer files from A to B and delete them from A before they get to B, they will persistently show up in B's "Out of Sync Items" list while it is transferring another file. Restarting B seems to get rid of these stale entries. The stale entries alone do not put B into an "Out of Sync" state.

@AudriusButkevicius
Copy link
Member

I think rescan on A should fix it.

@calmh
Copy link
Member

calmh commented Sep 3, 2016

Is this actually a bug? If so, what is it - is it the inotify interaction or something? It seems to be a natural consequence of changes happening (the delete) and not being scanned yet.

@alednz
Copy link
Author

alednz commented Sep 3, 2016 via email

@vontrapp
Copy link

"they will persistently show up in B's Out of Sync Items list while it is transferring another file"

Does this mean they no longer persist once B is done transferring? If so then I'm pretty sure I've seen this before myself, but clears itself up once syncing is 'finished'.

@graboluk
Copy link

I had to manually remove files to get all computers report "in sync", which to me is a bug. I'm now running 12.* series, so no point redoing the test, but I plan very soon to upgrade to 14.* after which I'll report if the issue is still there.

@lkwg82
Copy link
Contributor

lkwg82 commented Apr 14, 2017

Still relevant? Seems to be stale.

@alednz
Copy link
Author

alednz commented Apr 14, 2017 via email

@calmh calmh closed this as completed Apr 14, 2017
@st-review st-review added the frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion label Apr 15, 2018
@syncthing syncthing locked and limited conversation to collaborators Apr 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug A problem with current functionality, as opposed to missing functionality (enhancement) frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion
Projects
None yet
Development

No branches or pull requests

9 participants