Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve local discovery reaction time at startup #3278

Closed
calmh opened this issue Jun 7, 2016 · 2 comments
Closed

Improve local discovery reaction time at startup #3278

calmh opened this issue Jun 7, 2016 · 2 comments
Assignees
Labels
enhancement New features or improvements of some kind, as opposed to a problem (bug) frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion protocol Issues that require a change to the protocol (BEP, relay, discovery)

Comments

@calmh
Copy link
Member

calmh commented Jun 7, 2016

Once we refactor the local discovery protocol we should provide a reliable mechanism to detect a device that is restarting, and provide it with up to date local discovery information.

One idea on how to do this is to include a sequence number in our announcement packets. When a device receives an announcement from another device that it hasn't seen before, or an announcement with a lower sequence number that what it has previously seen for that device, it will respond with an announcement packet of it's own.

This resolves an issue where devices that restart would otherwise only have global discovery data for the first few moments and thus prefer external connections over local ones.

@calmh calmh added enhancement New features or improvements of some kind, as opposed to a problem (bug) protocol Issues that require a change to the protocol (BEP, relay, discovery) labels Jun 7, 2016
@calmh calmh added this to the v0.14 "Dysprosium Dragonfly" milestone Jun 7, 2016
@calmh
Copy link
Member Author

calmh commented Jun 7, 2016

Relates to #3080 and #3277.

@Getron
Copy link

Getron commented Jun 23, 2016

@calmh Agree, this would be great for local discovery speeds. Great idea.

@calmh calmh assigned calmh and Zillode and unassigned Zillode and calmh Jul 4, 2016
@st-review st-review added the frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion label Jul 4, 2017
@syncthing syncthing locked and limited conversation to collaborators Jul 4, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New features or improvements of some kind, as opposed to a problem (bug) frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion protocol Issues that require a change to the protocol (BEP, relay, discovery)
Projects
None yet
Development

No branches or pull requests

4 participants