Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

32-bit builds of v0.13.8 panic (386, arm) #3347

Closed
xduugu opened this issue Jun 26, 2016 · 8 comments
Closed

32-bit builds of v0.13.8 panic (386, arm) #3347

xduugu opened this issue Jun 26, 2016 · 8 comments
Labels
bug A problem with current functionality, as opposed to missing functionality (enhancement)

Comments

@xduugu
Copy link
Contributor

xduugu commented Jun 26, 2016

To fix: syncthing -upgrade and get the v0.13.9 release.

//@calmh


The latest linux arm release (0.13.8) panics for me. Removing the index does not help. Reverting to 0.13.7 fixes the issue.

Panic log:

[XXXXX] 12:36:28 INFO: syncthing v0.13.8 "Copper Cockroach" (go1.6.2 linux-arm) unknown-user@lx-buildslave.syncthing.net 2016-06-26 10:48:18 UTC
...
Panic at 2016-06-26T12:36:28Z
panic: runtime error: invalid memory address or nil pointer dereference
[signal 0xb code=0x1 addr=0x4 pc=0x366bc8]

goroutine 1 [running]:
panic(0x62a920, 0x10d0a038)
        /usr/local/go/src/runtime/panic.go:481 +0x330
sync/atomic.addUint64(0x1110e30c, 0x0, 0x0, 0x0, 0x0)
        /usr/local/go/src/sync/atomic/64bit_arm.go:31 +0x68
github.com/syncthing/syncthing/lib/db.readWriteTransaction.flush(0x10d136e0, 0x1110e300, 0x1110ef40)
        /home/buildslave/workspace/syncthing-release/src/github.com/syncthing/syncthing/lib/db/leveldb_transactions.go:74 +0xbc
github.com/syncthing/syncthing/lib/db.readWriteTransaction.close(0x10d136e0, 0x1110e300, 0x1110ef40)
        /home/buildslave/workspace/syncthing-release/src/github.com/syncthing/syncthing/lib/db/leveldb_transactions.go:59 +0x2c
github.com/syncthing/syncthing/lib/db.(*Instance).checkGlobals(0x1110e300, 0x111128c0, 0xd, 0x10, 0x10d524e4)
        /home/buildslave/workspace/syncthing-release/src/github.com/syncthing/syncthing/lib/db/leveldb_dbinstance.go:643 +0x870
github.com/syncthing/syncthing/lib/db.NewFileSet(0x11109fd0, 0xd, 0x1110e300, 0x10e6b3d4)
        /home/buildslave/workspace/syncthing-release/src/github.com/syncthing/syncthing/lib/db/set.go:104 +0x268
github.com/syncthing/syncthing/lib/model.(*Model).AddFolder(0x10d0c2c0, 0x11109fd0, 0xd, 0x0, 0x0, 0x1109bb00, 0x22, 0x0, 0x11081980, 0x3, ...)
        /home/buildslave/workspace/syncthing-release/src/github.com/syncthing/syncthing/lib/model/model.go:1378 +0xf8
main.syncthingMain(0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x6a4088, 0x1, 0x0, ...)
        /home/buildslave/workspace/syncthing-release/src/github.com/syncthing/syncthing/cmd/syncthing/main.go:688 +0x18f8
main.main()
        /home/buildslave/workspace/syncthing-release/src/github.com/syncthing/syncthing/cmd/syncthing/main.go:364 +0x748
@AndreB82
Copy link

Same error on Win x86 (Vista)

@xduugu
Copy link
Contributor Author

xduugu commented Jun 26, 2016

Linux amd64 works fine. Maybe this issue affects all 32-bit builds.

@xduugu
Copy link
Contributor Author

xduugu commented Jun 26, 2016

The linux i386 panics as well. I'll change the title of the issue.

@xduugu xduugu changed the title v0.13.8 panics on linux arm 32-bit builds of v0.13.8 panic Jun 26, 2016
@Kamiperat0r
Copy link

Same error for me on linux armv71(odroid XU4) and armv61(RPI 1b):

[KWXTT] INFO: syncthing v0.13.8 "Copper Cockroach" (go1.6.2 linux-arm) unknown-user@lx-buildslave.syncthing.net 2016-06-26 10:48:18 UTC
Jun 26 14:31:13 EDLSF syncthing[21364]: [KWXTT] INFO: My ID: KWXTTWN-TEPOF4B-IHPFKVY-357NLHH-ZVI4JS2-ML4CL5C-JE4MAXL-LYDRHAO
Jun 26 14:31:13 EDLSF syncthing[21364]: [KWXTT] INFO: Single thread hash performance is ~34 MB/s
Jun 26 14:31:13 EDLSF syncthing[21364]: [KWXTT] INFO: Local networks: 127.0.0.1/8, 192.168.1.101/24, ::1/128, fe80::21e:6ff:fe31:13f0/64
Jun 26 14:31:15 EDLSF syncthing[21364]: panic: runtime error: invalid memory address or nil pointer dereference
Jun 26 14:31:15 EDLSF syncthing[21364]: [signal 0xb code=0x1 addr=0x4 pc=0x363014]
Jun 26 14:31:15 EDLSF syncthing[21364]: goroutine 1 [running]:
Jun 26 14:31:15 EDLSF syncthing[21364]: panic(0x613780, 0x10d20030)
Jun 26 14:31:15 EDLSF syncthing[21364]: /usr/local/go/src/runtime/panic.go:481 +0x330
Jun 26 14:31:15 EDLSF syncthing[21364]: sync/atomic.addUint64(0x1115a7ac, 0x0, 0x0, 0x0, 0x0)
Jun 26 14:31:15 EDLSF syncthing[21364]: /usr/local/go/src/sync/atomic/64bit_arm.go:31 +0x68
Jun 26 14:31:15 EDLSF syncthing[21364]: github.com/syncthing/syncthing/lib/db.readWriteTransaction.flush(0x121eb410, 0x1115a7a0, 0x121eee40)
Jun 26 14:31:15 EDLSF syncthing[21364]: /home/buildslave/workspace/syncthing-release-debian/src/github.com/syncthing/syncthing/lib/db/leveldb_transactions.go:74 +0xbc
Jun 26 14:31:15 EDLSF syncthing[21364]: github.com/syncthing/syncthing/lib/db.readWriteTransaction.close(0x121eb410, 0x1115a7a0, 0x121eee40)
Jun 26 14:31:15 EDLSF syncthing[21364]: /home/buildslave/workspace/syncthing-release-debian/src/github.com/syncthing/syncthing/lib/db/leveldb_transactions.go:59 +0x2c
Jun 26 14:31:15 EDLSF syncthing[21364]: github.com/syncthing/syncthing/lib/db.(_Instance).checkGlobals(0x1115a7a0, 0x121eee00, 0x11, 0x20, 0x121d8bc4)
Jun 26 14:31:15 EDLSF syncthing[21364]: /home/buildslave/workspace/syncthing-release-debian/src/github.com/syncthing/syncthing/lib/db/leveldb_dbinstance.go:643 +0x870
Jun 26 14:31:15 EDLSF syncthing[21364]: github.com/syncthing/syncthing/lib/db.NewFileSet(0x110dfc60, 0x11, 0x1115a7a0, 0x10e893dc)
Jun 26 14:31:15 EDLSF syncthing[21364]: /home/buildslave/workspace/syncthing-release-debian/src/github.com/syncthing/syncthing/lib/db/set.go:104 +0x268
Jun 26 14:31:15 EDLSF syncthing[21364]: github.com/syncthing/syncthing/lib/model.(_Model).AddFolder(0x10d88000, 0x110dfc60, 0x11, 0x0, 0x0, 0x1115bf80, 0x12, 0x0, 0x110d3880, 0x2, ...)
Jun 26 14:31:15 EDLSF syncthing[21364]: /home/buildslave/workspace/syncthing-release-debian/src/github.com/syncthing/syncthing/lib/model/model.go:1378 +0xf8
Jun 26 14:31:15 EDLSF syncthing[21364]: main.syncthingMain(0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x1, 0x68b6dc, 0x1, 0x0, ...)
Jun 26 14:31:15 EDLSF syncthing[21364]: /home/buildslave/workspace/syncthing-release-debian/src/github.com/syncthing/syncthing/cmd/syncthing/main.go:688 +0x18f8
Jun 26 14:31:15 EDLSF syncthing[21364]: main.main()
Jun 26 14:31:15 EDLSF syncthing[21364]: /home/buildslave/workspace/syncthing-release-debian/src/github.com/syncthing/syncthing/cmd/syncthing/main.go:364 +0x748
Jun 26 14:31:15 EDLSF systemd[1]: syncthing@root.service: Main process exited, code=exited, status=2/INVALIDARGUMENT
Jun 26 14:31:15 EDLSF systemd[1]: syncthing@root.service: Unit entered failed state.
Jun 26 14:31:15 EDLSF systemd[1]: syncthing@root.service: Failed with result 'exit-code'.

Revert to 0.13.7 solve

@xduugu
Copy link
Contributor Author

xduugu commented Jun 26, 2016

I guess it is because of commit b779e22. The fix is the same as 707837b.

@xduugu
Copy link
Contributor Author

xduugu commented Jun 26, 2016

I've created a pull request #3350. The builds at https://build.syncthing.net/job/syncthing-pr/2516/artifact/ fix the issue for me on linux arm and i386.

@calmh
Copy link
Member

calmh commented Jun 26, 2016

Reopening for visibility

@calmh calmh reopened this Jun 26, 2016
@calmh calmh changed the title 32-bit builds of v0.13.8 panic 32-bit builds of v0.13.8 panics (386, arm) Jun 26, 2016
@calmh calmh changed the title 32-bit builds of v0.13.8 panics (386, arm) 32-bit builds of v0.13.8 panic (386, arm) Jun 26, 2016
@calmh
Copy link
Member

calmh commented Jun 26, 2016

Resolved in v0.13.9 that I'm pushing now.

@syncthing syncthing locked and limited conversation to collaborators Jun 26, 2016
@calmh calmh added the bug A problem with current functionality, as opposed to missing functionality (enhancement) label Jun 26, 2016
@calmh calmh closed this as completed Jul 2, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug A problem with current functionality, as opposed to missing functionality (enhancement)
Projects
None yet
Development

No branches or pull requests

4 participants