Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Buffer the device/folder rejected messages so the GUI gets them even when connecting later #4084

Closed
bugith opened this issue Apr 6, 2017 · 6 comments
Closed

Buffer the device/folder rejected messages so the GUI gets them even when connecting later #4084

bugith opened this issue Apr 6, 2017 · 6 comments
Labels
enhancement New features or improvements of some kind, as opposed to a problem (bug) frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion

Comments

@bugith
Copy link

bugith commented Apr 6, 2017 •
edited

When launching the GUI, Accept/Refuse new device or folder won't show immediately although many other infos are displayed.
Could it be possible to have the core to store such requests in RAM (until the source stops its request) and have them passed to the GUI on launch (or have the GUI on launch to question the core for such recent requests)?
@calmh
Copy link
Member

calmh commented Apr 6, 2017

Yes, we should probably do something about that.

@calmh calmh changed the title Notification won't show immediately on GUI launch Buffer the device/folder rejected messages so the GUI gets them even when connecting later May 4, 2017
@calmh calmh added the enhancement New features or improvements of some kind, as opposed to a problem (bug) label May 4, 2017
@calmh calmh added this to the Unplanned (Contributions Welcome) milestone May 4, 2017
@calmh
Copy link
Member

calmh commented May 4, 2017

One way to solve this today would be to set up a separate subscription for the relevant events only and have the GUI poll that.

@calmh calmh removed this from the Unplanned (Contributions Welcome) milestone Feb 11, 2018
@xor-gate xor-gate mentioned this issue Jul 10, 2018
Closed
@AudriusButkevicius
Copy link
Member

This should probably be turned into a persisted in config thing to survive restarts and add free deduplication.

@calmh
Copy link
Member

calmh commented Jul 12, 2018 •
edited

Maybe. The separate subscription mentioned above is implemented(-able) today though. That gives you a thousand event buffer for just these types.

@AudriusButkevicius
Copy link
Member

Sure, yet it does not deduplicate (which all the clients have to implement), nor is it persisted between restarts, which it probably should be.

@xor-gate xor-gate mentioned this issue Jul 13, 2018
Open
@imsodin
Copy link
Member

imsodin commented Oct 11, 2018

Fixed by #5084

@imsodin imsodin closed this as completed Oct 11, 2018
@st-review st-review added the frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion label Oct 12, 2019
@syncthing syncthing locked and limited conversation to collaborators Oct 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New features or improvements of some kind, as opposed to a problem (bug) frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@calmh @AudriusButkevicius @bugith @imsodin @st-review