Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting up *no* Ignore folder behave different on MAC / WIN if .stignore already exists in directory #5850

Closed
sisu4syncthing opened this issue Jul 11, 2019 · 7 comments
Labels
frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion

Comments

@sisu4syncthing
Copy link

Hi,

v1.2.0 on MacOSX 10.12.6 and Win7 64Bit

I'm using Waterfox Browser on Mac but Safari does the same here.

Issue:
Setting up a new folder on a Mac and a Win7 System and having already .stignore files in a pre-existing directory will do not the same.

What I do and how to reproduce:

1.0. Open 2 private tabs in Browser (I do it on the Mac). Tab1 for Win7-Syncthing-WebGui, Tab2 for Mac-Syncthing-WebGui.
2.0. Choose Add Folder on Tab1+2
2.1. Folder Label and Folder ID: Test-Ignore
2.2. Folder Path points to a directory containing some files of your choice, and:

.stfolder
.stignore
.stignore_global
.stignore_specific

content of .stignore

!.stignore_global
!.stignore_specific

#include .stignore_global
#include .stignore_specific 

.stignore_global and .stignore_specific only containing two slashes //
.stfolder is a 0 byte file
all files are set hidden (on windows via attributes)

2.3. click through every tab, from left to right now to set up your folder.
2.4. you can skip configuring the sharing tab, as we don't want to share something to another device.
2.5. you can skip configuring the versioning tab too
2.6. if you click onto the Ignore Patterns tab, you may or may not recognize a cursor in the textfield "Enter ignore patterns". (This is the reason, I think different behaviour is triggered: If a cursor is seen, .stignore is configured, if no cursor is seen, no .stignore is configured)
2.7. click to Advanced tab and activate up Watch for Changes and Ignore permissions.
3.0. now press SAVE on both tabs1+2 to save your settings.

On the Win7 syncthing, I now see the new folder with "Reduced by ignore patterns"
But not on the Mac syncthing.

4.0. If I EDIT the created folder and check the Ignore Pattern tab,
I see

!.stignore_global
!.stignore_specific

#include .stignore_global
#include .stignore_specific

on the Win7 syncthing
and nothing on the Mac syncthing.

Maybe you can skip steps 2.3 - 2.5. and 2.7. and directly go to the Ignore Patterns tab.

What do I expect?
Same result from both the Win7 and Mac Browser tabs.

@imsodin
Copy link
Member

imsodin commented Jul 12, 2019

So the short version of the problem is: A .stignore file in the folder root is not recognized by Syncthing on mac, correct?

@sisu4syncthing
Copy link
Author

Sounds good to me :-)

@AudriusButkevicius
Copy link
Member

I don't think its not not recognised. I suspect it's just a UI display bug of the "reduced by bla bla" not showing up.

@imsodin
Copy link
Member

imsodin commented Jul 18, 2019

This part sounds like it is really not recognised:

4.0. If I EDIT the created folder and check the Ignore Pattern tab,
I see
[...]
on the Win7 syncthing
and nothing on the Mac syncthing.

It would be nice if someone with access to a mac could try to reproduce this.

@AudriusButkevicius
Copy link
Member

To be honest, this doesn't seem possible, there is no platform specific handling of this, so it must be a UI issue.

@sisu4syncthing
Copy link
Author

Maybe it is kinda OSX related, because the "bug" is browser related?

@calmh
Copy link
Member

calmh commented Apr 1, 2020

I can't reproduce this on Mac with Safari nor Edge -- as long as nothing is typed into the ignore patterns field on folder creation, the existing .stignore is left alone and loaded.

@calmh calmh closed this as completed Apr 1, 2020
@st-review st-review added the frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion label Apr 2, 2021
@syncthing syncthing locked and limited conversation to collaborators Apr 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion
Projects
None yet
Development

No branches or pull requests

5 participants