Page numbering on "Out of Sync" pop-up

[Grace-Court]

The "number of items to display" option at the foot of the pop-up page is (thankfully!) persistent, but so is the page number. When the pop-up page is closed (either with the "Close" button or by clicking on originating page "behind" the pop-up page), the page number that was being displayed is also persistent, so that on re-opening the pop-up (which always displays page 1 of the refreshed list), the page number displayed is wrong - should be 1, of course.

A very, VERY minor bug in a superb package!

May I be a nuisance and - as it's related to the same part of SyncThing - mention a preference? It would be good if the page selector could be at the top of the pop-up as well as it would save a lot of scrolling when 50 items are being displayed.

Version Information

Syncthing Version: v1.3.4 (Linux 64-bit)
OS Version: Windows 7 (for SyncThing monitoring)
Browser Version: Firefox 74 (64-bit)

[AudriusButkevicius]

https://docs.syncthing.net/users/faq.html#is-it-syncthing-syncthing-or-syncthing

You should just adjust the page size to something that fits on your screen so you don't have to scroll.

Adding a second time on the top is a fake improvement, given the selectors take up vertical space as well, reducing what's visible even more.

[Grace-Court]

https://docs.syncthing.net/users/faq.html#is-it-syncthing-syncthing-or-syncthing

Oops! :-)

You should just adjust the page size to something that fits on your screen so you don't have to scroll.

Adding a second time on the top is a fake improvement, given the selectors take up vertical space as well, reducing what's visible even more.

My laptop's screen means that the text would be unreadable even if I could display at the necessary resolution, but I take your point. Adjusting "zoom" on that tab on Firefox to 67% and choosing 25 items/page as a compromise has made it workable, though...

[calmh]

The PR said that it doesn't fix this issue, so I think GitHub misunderstood slightly.

[Yithis]

I wanted to inspect this issue, but as I tried to recreate it neither page number nor number of items to display were persistent. @Grace-Court Did bug occurred on Linux or Windows? Can you write what are the steps to recreate this?

[AudriusButkevicius]

I think it happens as the number of items backing the table changes, so it allows you to pick options which are no longer valid if you refreshed the table.

[imsodin]

No changes necessary, you just need more than 10 (20? whatever is the minimum number of items per page) out of sync or failed items, then do

1. Open item list.
2. Switch to second page.
3. Close and reopen modal.

Expected result:
Either reopen at the same place (page 2), or back on page 1, with the correct page selected at the bottom.

Observed result:
Items of page 2 are displayed, but page 1 is selected at the bottom.

Occurred on both firefox and chromium on linux (debian testing 64bit). I last tested a while ago (when doing the PR linked above), however there weren't any relevant changes.

[Grace-Court]

@Grace-Court Did bug occurred on Linux or Windows? Can you write what are the steps to recreate this?

Occurred on Linux... I noticed it when I had a large number of large files to sync, so the "live" refresh wasn't differing by very much between views. In the post immediately above, imsodin summarises the issue perfectly, the observed result not being the expected result.

A very minor bug, and perhaps best addressed by simply causing the list of queued files to be refreshed on the pop-up window with the page number reset to 1 on being re-opened?

[Yithis]

I manage to recreate bug and it looks like adding old fields for items per page and page number is solving issue. The problem for this solution is when you change page number or amount of items per page in one pop-up page (for example in changed items) it will change those parameters in all other pages (for example failed items). To solve this I would need to create 8 different fields and I wasn't sure if it is something you would like to see. Is this solution good enough or should I change something?