Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] Investigate integration with Apicur.io #2698

Closed
dongniwang opened this issue May 22, 2018 · 8 comments
Closed

[UX] Investigate integration with Apicur.io #2698

dongniwang opened this issue May 22, 2018 · 8 comments
Assignees
Labels
group/uxd User experience (UX) designs

Comments

@dongniwang
Copy link
Contributor

Placehoder issue for apicur.io UX work

@pure-bot pure-bot bot added the notif/triage The issue needs triage. Applied automatically to all new issues. label May 22, 2018
@dongniwang dongniwang self-assigned this May 22, 2018
@heiko-braun heiko-braun added this to the Sprint 31 (3/5) milestone Jun 26, 2018
@dongniwang
Copy link
Contributor Author

UX design for Apicurio integration is available for review via UX tracker. Thank you!

@gashcrumb
Copy link
Contributor

I've left some comments, I think there's a few tweaks needed.

Also an important point is at the F2F a lot of concern was raised about having a whole new app embedded in the context of a wizard. As the page flow is, upload/import some file, look at a review, then you click a button and poof you're in a new complicated editor, you make some changes, click 'Done' or 'Save' but then you're not actually done, you still have to finish the wizard.

What if the user needs to go to lunch midway through this? I don't know what kind of persistence is available at this point, i.e. is the file saved? When are my changes in apicurio saved?

I feel like we should reconsider how this integration works again, wouldn't it make more sense to only offer editing the API definition after it's been imported as an option off of the connection details page or off of the API connector detail page.

Also, I'm kinda questioning embedding apicurio vs having it a separate page. Embedding it fattens up the UI's dependency tree more, we're adding another app that needs to get downloaded as the app starts up. Though if it's a separate page, then it really doesn't make sense to me to have it as part of a wizard.

@kahboom @kcbabo @gaughan thoughts? If I'm making crazy talk just ignore me :-)

@amysueg
Copy link

amysueg commented Jun 27, 2018

@gashcrumb The design was predicated on the decision to embed apicur.io. Further discussion led us to conclude that it would be a natural part of the API connector flow and thus led to including it in the wizard. We added the full-screen mode so that a user wouldn't be confined to that small screen area for editing.

I hear what you're saying about persistence and going to lunch (!) though. So that is important, and work should not be lost if the user steps away (from anything in Syndesis).

@kahboom
Copy link
Contributor

kahboom commented Jun 28, 2018

Thank you @dongniwang for the designs, and for ensuring to clarify that error validation and more complex UI enhancements should be reserved for 7.2. Feedback on the existing designs, based on the embedded route:

  • For Step 1, I thought we agreed to rename "Swagger Specification" to "OpenAPI Specification"? See discussion here.
  • For Step 2, do we still want to show Errors in a negative way to users, implying that they've made a mistake? I listed that as feedback from John Varhaeg @jpav in the doc here.
  • +1 to the change to "Review/Edit API Definition"
  • Within the editor, there was some discussion about having two Cancel buttons and the Done button in the same UXD walkthrough above (link). Are we making any changes about this?

Some additional discussions in the UXD walkthrough slide deck that I think are a bit more up-to-date.


@gashcrumb - I'm sure @kcbabo can chime on on the idea of integrating, or even embedding, Apicurio as a whole.

At the F2F, there were a lot of different and conflicting opinions about where/if Apicurio should be a part of the API connector user flow, which I've outlined here.

Persistence is always done on the Syndesis side, and if the user went to a long lunch, I would think it's kind of the same situation they'd run into if they were creating an integration or connection? We could add the option to save as a draft, of course, for the next release, if that's a major concern.

@gashcrumb
Copy link
Contributor

Yep, just had a call and we're on the same page, so +1 with some changes that @dongniwang is working on right now. @kahboom how is #2886 coming along?

@gashcrumb
Copy link
Contributor

We've decided that Syndesis makes folks so efficient, they don't need to stop and have lunch but can instead get their work done quickly in a single session :-)

@dongniwang
Copy link
Contributor Author

V2 of UX design is available here. Please review. Thank you!

@paoloantinori paoloantinori added group/uxd User experience (UX) designs and removed notif/triage The issue needs triage. Applied automatically to all new issues. labels Jul 4, 2018
@heiko-braun heiko-braun added this to To do in Sprint 31 - Tasks Jul 5, 2018
@heiko-braun heiko-braun moved this from To do to In progress in Sprint 31 - Tasks Jul 5, 2018
@dongniwang
Copy link
Contributor Author

See latest UX design via UX tracker. Closing this issue for now.

I will open a new issue to explore some design options to address the concern about not giving user context and share that with the team later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
group/uxd User experience (UX) designs
Projects
No open projects
Development

No branches or pull requests

6 participants