Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polyfills and shims needed for Angular 6 upgrade #2978

Closed
kahboom opened this issue Jul 5, 2018 · 3 comments
Closed

Polyfills and shims needed for Angular 6 upgrade #2978

kahboom opened this issue Jul 5, 2018 · 3 comments
Assignees
Labels
cat/bug A bug which needs fixing group/ui User interface SPA, talking to the REST backend prio/p1 The priority of a bug. p1 means high
Projects

Comments

@kahboom
Copy link
Contributor

kahboom commented Jul 5, 2018

This is a...


[ ] Feature request
[ ] Regression (a behavior that used to work and stopped working in a new release)
[x] Bug report  
[ ] Documentation issue or request

The problem

After rebasing and using the latest changes with Angular 6.0.4 I started to get the following error coming from the yamljs package when I'd try to rebuild with yarn ng build --aot=false --vendor-chunk=true --source-map=true or even just syndesis build --clean, which uses the same command.

Screenshot

ERROR in ./node_modules/yamljs/lib/Utils.js
Module not found: Error: Can't resolve 'fs' in '/Users/kahboom/Projects/syndesis/app/ui/node_modules/yamljs/lib'

screenshot 2018-07-04 23 19 44

See my comment here for more details.

I also got a few other weird things related to SASS:

Module build failed: Error: Node Sass does not yet support your current environment: OS X 64-bit with Unsupported runtime (64)

screenshot 2018-07-04 22 02 51

EDIT: This should be resolved with this PR #2886 .

@kahboom kahboom added cat/bug A bug which needs fixing group/ui User interface SPA, talking to the REST backend labels Jul 5, 2018
@kahboom kahboom self-assigned this Jul 5, 2018
@pure-bot pure-bot bot added the notif/triage The issue needs triage. Applied automatically to all new issues. label Jul 5, 2018
@heiko-braun heiko-braun added this to Backlog in Bug Backlog Jul 5, 2018
@gashcrumb
Copy link
Contributor

@kahboom run yarn install --force before running yarn start:minishift to sort the node-saas issue.

@paoloantinori
Copy link
Contributor

@kahboom is this still a bug or do @gashcrumb suggestion fixes it?

@paoloantinori paoloantinori added prio/p1 The priority of a bug. p1 means high and removed notif/triage The issue needs triage. Applied automatically to all new issues. labels Jul 18, 2018
@kahboom
Copy link
Contributor Author

kahboom commented Jul 19, 2018

Well, if this is the same issue I'm thinking of, I was trying to come up with a fix that would work for everyone without having to use the --force flag. I think this is related to the version of Node and npm each person uses and dependencies that try to force certain engine versions. Either way, this commit would have sorted out for local env, but not for CD/CI: https://github.com/syndesisio/syndesis/pull/2886/files#diff-4c51b5da64219cce10752e61a6393f5c

I guess either way we can consider this closed and just have people run those commands manually, or that fix above should sort it out.

@kahboom kahboom closed this as completed Jul 19, 2018
@project-bot project-bot bot moved this from Backlog to Closed in Bug Backlog Jul 19, 2018
@heiko-braun heiko-braun added this to the Sprint 32 (4/5) milestone Aug 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat/bug A bug which needs fixing group/ui User interface SPA, talking to the REST backend prio/p1 The priority of a bug. p1 means high
Projects
No open projects
Bug Backlog
  
Closed
Development

No branches or pull requests

4 participants