Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected behavior when editing an integration while in building process #3095

Closed
mcada opened this issue Jul 17, 2018 · 7 comments
Closed
Assignees
Labels
cat/bug A bug which needs fixing group/ui User interface SPA, talking to the REST backend prio/p1 The priority of a bug. p1 means high source/qe Raised by QE
Projects

Comments

@mcada
Copy link
Contributor

mcada commented Jul 17, 2018

This is a...


[ ] Feature request
[ ] Regression (a behavior that used to work and stopped working in a new release)
[x] Bug report  
[ ] Documentation issue or request

The problem

If you edit integration when its in building state and delete any step, it will reappear again.

Tasks involved / Steps to Reproduce

  1. Create an integration (I tested it with database --> log --> database)
  2. Click on publish
  3. Edit the integration while its building
  4. Delete one step
  5. The step will reappear after few seconds

out

Sometimes it breaks in different way and this happens:
out

@mcada mcada added the prio/p1 The priority of a bug. p1 means high label Jul 17, 2018
@pure-bot pure-bot bot added the notif/triage The issue needs triage. Applied automatically to all new issues. label Jul 17, 2018
@tplevko tplevko added the source/qe Raised by QE label Jul 17, 2018
@gashcrumb
Copy link
Contributor

gashcrumb commented Jul 17, 2018

Hmm, this is due to the integration being fetched as the UI is notified of changes, causing the step array to be reloaded. I can probably do some comparison and prevent this from happening though.

The only drawback I see is if 2 browsers have an integration open, one makes changes and saves it, the other browser wouldn't see that change unless they exit the editor and go back in.

So if we want that behavior should we disable the edit button while the integration is publishing. I'm not sure, @dongniwang @sjcox-rh thoughts?

@gashcrumb gashcrumb self-assigned this Jul 17, 2018
@gashcrumb gashcrumb added group/ui User interface SPA, talking to the REST backend cat/bug A bug which needs fixing and removed notif/triage The issue needs triage. Applied automatically to all new issues. labels Jul 17, 2018
@gashcrumb
Copy link
Contributor

It's possible we may have to defer this one for when we tackle the saving user story (#3048)

@dongniwang
Copy link
Contributor

So if we want that behavior should we disable the edit button while the integration is publishing.

This was my first thought as well. Any foreseeable drawbacks?

@gashcrumb
Copy link
Contributor

shrugs

@heiko-braun heiko-braun added this to Backlog in Bug Backlog Jul 18, 2018
@sjcox-rh
Copy link
Contributor

sjcox-rh commented Jul 20, 2018

@gashcrumb @dongniwang agreed. Since editing while an integration is in the publish state can potentially cause problems, why allow them to edit? +1 for disabling.

Unless I'm missing use cases where editing capability is necessary while publishing. Only concern is if user tries to go into edit mode and is confused as to why the button it's disabled. Perhaps a tooltip explaining?

@gashcrumb
Copy link
Contributor

Will disable the edit links while an integration is pending as part of the work for #3180

@gashcrumb
Copy link
Contributor

Disabled the edit links in #3183

@project-bot project-bot bot moved this from Has Milestone to Closed in Bug Backlog Jul 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat/bug A bug which needs fixing group/ui User interface SPA, talking to the REST backend prio/p1 The priority of a bug. p1 means high source/qe Raised by QE
Projects
No open projects
Bug Backlog
  
Closed
Development

No branches or pull requests

5 participants