New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unexpected behavior when editing an integration while in building process #3095
Comments
Hmm, this is due to the integration being fetched as the UI is notified of changes, causing the step array to be reloaded. I can probably do some comparison and prevent this from happening though. The only drawback I see is if 2 browsers have an integration open, one makes changes and saves it, the other browser wouldn't see that change unless they exit the editor and go back in. So if we want that behavior should we disable the edit button while the integration is publishing. I'm not sure, @dongniwang @sjcox-rh thoughts? |
It's possible we may have to defer this one for when we tackle the saving user story (#3048) |
This was my first thought as well. Any foreseeable drawbacks? |
shrugs |
@gashcrumb @dongniwang agreed. Since editing while an integration is in the publish state can potentially cause problems, why allow them to edit? +1 for disabling. Unless I'm missing use cases where editing capability is necessary while publishing. Only concern is if user tries to go into edit mode and is confused as to why the button it's disabled. Perhaps a tooltip explaining? |
Will disable the edit links while an integration is pending as part of the work for #3180 |
Disabled the edit links in #3183 |
This is a...
The problem
If you edit integration when its in building state and delete any step, it will reappear again.
Tasks involved / Steps to Reproduce
Sometimes it breaks in different way and this happens:
The text was updated successfully, but these errors were encountered: